Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753414AbdF2Oa4 (ORCPT ); Thu, 29 Jun 2017 10:30:56 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:55140 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753350AbdF2Oap (ORCPT ); Thu, 29 Jun 2017 10:30:45 -0400 Date: Thu, 29 Jun 2017 16:30:43 +0200 From: Greg KH To: Quytelda Kahja Cc: david.kershner@unisys.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Staging: unisys: visorbus: Fix coding style warning from checkpatch.pl. Message-ID: <20170629143043.GA19099@kroah.com> References: <20170628024905.3000-1-quytelda@tamalin.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170628024905.3000-1-quytelda@tamalin.org> User-Agent: Mutt/1.8.3 (2017-05-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 550 Lines: 17 On Tue, Jun 27, 2017 at 07:49:05PM -0700, Quytelda Kahja wrote: > Replace the literal function name "visorbus_create_instance" with the format > specifier "%s" so it can be dynamically filled by the __func__ macro. > > Signed-off-by: Quytelda Kahja > --- > drivers/staging/unisys/visorbus/visorbus_main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) When you make a new version of a patch, always correctly version it, as the documentation tells you to do. Please fix that up here and resend. thanks, greg k-h