Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753423AbdF2PBn convert rfc822-to-8bit (ORCPT ); Thu, 29 Jun 2017 11:01:43 -0400 Received: from mx36-44.antispamcloud.com ([209.126.121.60]:60195 "EHLO mx36-44.antispamcloud.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752830AbdF2PBg (ORCPT ); Thu, 29 Jun 2017 11:01:36 -0400 X-Greylist: delayed 2981 seconds by postgrey-1.27 at vger.kernel.org; Thu, 29 Jun 2017 11:01:36 EDT Subject: Re: [PATCH v2] hwmon: Add LTC2471/LTC2473 driver To: Guenter Roeck , Lars-Peter Clausen , CC: , , "linux-iio@vger.kernel.org" , Jonathan Cameron References: <1498733135-4729-1-git-send-email-mike.looijmans@topic.nl> <1498738434-18252-1-git-send-email-mike.looijmans@topic.nl> From: Mike Looijmans Organization: TOPIC Message-ID: <26126017-55d8-3d38-f5de-c764ca9ec699@topic.nl> Date: Thu, 29 Jun 2017 16:11:42 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: nl Content-Transfer-Encoding: 8BIT X-Originating-IP: [192.168.80.121] X-EXCLAIMER-MD-CONFIG: 9833cda7-5b21-4d34-9a38-8d025ddc3664 X-EXCLAIMER-MD-BIFURCATION-INSTANCE: 0 X-Originating-IP: 37.74.225.130 X-SpamExperts-Domain: topic.nl X-SpamExperts-Username: 37.74.225.128/28 Authentication-Results: antispamcloud.com; auth=pass smtp.auth=37.74.225.128/28@topic.nl X-SpamExperts-Outgoing-Class: ham X-SpamExperts-Outgoing-Evidence: SB/global_tokens (0.00503177628581) X-Recommended-Action: accept X-Filter-ID: PqwsvolAWURa0gwxuN3S5YEa3T7JuZT23fGO2rGt3ZgWMD8gia7lRmdoHJ3n0cm6Vtfp9X1ZBchZ wvx8a7dTUQWF0kx98HH3GX+iQK7NiP6LBDMrD7q/cJogwbqzsuokIXMJ1U4MKKnQ5SAJ1V9dkP9x bu57BDazLmklZgT7xzZqTmqm4lu5vpilCe7tHOhXy3n7us4tP7G/S50map/HxtGpABKFqXGwzdIH EoCW/c48CVsONrMJuGzuoGnKTKcygLJjfy2/hUPxxGqITycuLMdYaphGvYopQ24KJ9kgRDN3pbXn aMbbC1QSUBxihEsjBWOBqoptsYkcljagCMIDypReAQCFQo+KUtaSCrVTlxOfVsst/QEVbupaaYfx KYRJ8ar4sO9kYmr7/nmchPR9GwS0RTbIegwn2yn+XE4z9zMbAT/bTGM3eqpSRQBxZnohtAQ/w1mA oZf3jyxdAqp7oJQo65M4ugfrirkpW0oevJMZQGxcFxcrkq+IKIlinlm7VgW9/bktU41htiJ8fk7N kPOW6bvL9DC431WlF1LxckxMBAJkcsAhDD4OTTRkzMU8KuR9h4rJ1IhRjQc5xQiShDARG1B+1fix IwHJAR6hCNRFRFR4qXE7Cn+3zlGq5KdMR0tMwLh/UfgIMsW8UawravVdyPOcJwZf+mGEJuzRRI++ zePTgGGfpMtDmN7tmKvET4Zlh2MECg43BO8NgufPE3kSKxYQuSMZawsGweennaem7mIwv8Qxg6rP lrICCHCcqzZ55BUL3SkT8b3ga3j7d9TxgGIiYt9v/KHJqM8m23cMe8GSdIH2qFKFrSRPPbJVOqw5 9LUzlXJicKiPCbtp3jSxvQTOw1pelRpKVI2hE/tnRXffYQbDj3ueHdiCfTY8t8C9mOBdONdnsxgs k1D2pwpv8LVTTKXkszIMEXppVwwklVdKFwX1WMjdfSHaeMMfPis0P6IgXH+1HFas8bv3OVgbEtxG bfWvsckv3Tqu01LXiAMHUEtafRqcYx3lVcgTMgJuG0+JuqyOItgNr4hBl1EvIoQaTonBr36ufNH8 bWp1ijusC92JsNjXzHCGScYBtLGhGCKH2m0Rm1zmvdhzZE7MIK/puPFFkUm0Fg7eHWI= X-Report-Abuse-To: spam@quarantine2.antispamcloud.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1326 Lines: 40 On 29-06-17 15:40, Guenter Roeck wrote: > On 06/29/2017 05:30 AM, Lars-Peter Clausen wrote: >> On 06/29/2017 02:13 PM, Mike Looijmans wrote: >>> The LTC2741 and LTC2473 are single voltage monitoring chips. The LTC2473 >>> is similar to the LTC2471 but outputs a signed differential value. >>> >>> Datasheet: >>> http://cds.linear.com/docs/en/datasheet/24713fb.pdf >> >> This looks more like a general purpose ADC rather than a specialized voltage >> monitoring chip. In my opinion this driver would be better suited for the >> IIO framework. But before you start working on that lets try to hear what >> others think about this. >> > > Agreed (I just replied to that on another thread). Took a peek at the IIO drivers, looks simple enough, so I suggest to drop this patch and I'll create an IIO driver instead. The ltc2485 (as suggested by Guenter on that other thread) is pretty similar indeed, it might be feasible to join the two and have one driver handle them both. That would be preferred over a separat driver, right? Kind regards, Mike Looijmans System Expert TOPIC Products Materiaalweg 4, NL-5681 RJ Best Postbus 440, NL-5680 AK Best Telefoon: +31 (0) 499 33 69 79 E-mail: mike.looijmans@topicproducts.com Website: www.topicproducts.com Please consider the environment before printing this e-mail