Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752538AbdF2P6N (ORCPT ); Thu, 29 Jun 2017 11:58:13 -0400 Received: from mail.free-electrons.com ([62.4.15.54]:40962 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751830AbdF2P6G (ORCPT ); Thu, 29 Jun 2017 11:58:06 -0400 Date: Thu, 29 Jun 2017 17:57:46 +0200 From: Maxime Ripard To: Jonathan Liu Cc: David Airlie , Chen-Yu Tsai , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@googlegroups.com Subject: Re: [PATCH v7] drm/sun4i: hdmi: Implement I2C adapter for A10s DDC bus Message-ID: <20170629155746.ux5embr7tdo7k4xr@flea> References: <20170628105224.6619-1-net147@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="q74cbfwzekb6o244" Content-Disposition: inline In-Reply-To: <20170628105224.6619-1-net147@gmail.com> User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2010 Lines: 57 --q74cbfwzekb6o244 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Wed, Jun 28, 2017 at 08:52:24PM +1000, Jonathan Liu wrote: > The documentation for drm_do_get_edid in drivers/gpu/drm/drm_edid.c state= s: > "As in the general case the DDC bus is accessible by the kernel at the I2C > level, drivers must make all reasonable efforts to expose it as an I2C > adapter and use drm_get_edid() instead of abusing this function." >=20 > Exposing the DDC bus as an I2C adapter is more beneficial as it can be us= ed > for purposes other than reading the EDID such as modifying the EDID or > using the HDMI DDC pins as an I2C bus through the I2C dev interface from > userspace (e.g. i2c-tools). >=20 > Implement this for A10s. >=20 > Signed-off-by: Jonathan Liu Please wait before the discussion stops before sending the new version. We still have one ongoing on the v5, and you sent v6 and v7 in between. Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com --q74cbfwzekb6o244 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIcBAEBAgAGBQJZVSN6AAoJEBx+YmzsjxAgmx4P/ioHqIt66sQJmergNm1Wl9bk kV936z9N+6uRl5bpDUT1X5QGG45JYxGB/UP9UgUHH//DXHuYHUeTH5XQE692P/By ArGno57+9WzDYb3XwcPXqG+IQD1mlI82ib14bH/DAiJAolKjoqW9rJNqGcKVyW9h tMombdQ7+SPdOJ9OlQaoZPYn9Xk+HbUb2o/tAMGmB8hfzJ0QlsrJCqduVwuHdcW9 ZG7yp8vrPjD69b+uUGPezzxpz18bo8tuTLD/y/SaxrFdKNpVXFZdmbh2z8O3V95R 51cVjeI4slpKglYTnap5hoGlKgKuLNpkCIXqPwZ+TiI3YsIISo3Q+FCLlPGjlHgV OmCckR5cJ0JfqUIwZWcd/cbw/AEojG114ql6lCjjGruMXx+JDghta7Dfi2oEuICQ +xj3qBOoev+0/jDgkXn1abJ6AqM2bJiiWCswSjmrynr9chyrIfkrsx/x9oe9KtCv 5L3sigwDM+0CoT4vBhhgpkei1fV6OA+pLYEP5nAFChmUT9F2d9VLnjmgjtorm/WW DQfKKvimoTO4+iOLgAr6/cGHnrWa1Uc44oRzoEMJZq6dDuJc8oY2WsMX/il5+LGU oYukVxGyVdOTKUu1PiUZ/qXMyZ/4qmX6YiziXgcv7QZCnN7A7hPvTLg5huJCWGqu NuCK+lWfATxdZ1sgfNS9 =DzXR -----END PGP SIGNATURE----- --q74cbfwzekb6o244--