Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753109AbdF2QL1 (ORCPT ); Thu, 29 Jun 2017 12:11:27 -0400 Received: from mail-it0-f50.google.com ([209.85.214.50]:37152 "EHLO mail-it0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753028AbdF2QLN (ORCPT ); Thu, 29 Jun 2017 12:11:13 -0400 MIME-Version: 1.0 In-Reply-To: <5954C262.9000502@iogearbox.net> References: <1498717781-29151-1-git-send-email-mpe@ellerman.id.au> <5954C262.9000502@iogearbox.net> From: Kees Cook Date: Thu, 29 Jun 2017 09:11:10 -0700 X-Google-Sender-Auth: QwV8HKrHAZs8eTvDZmC4xaB5Dow Message-ID: Subject: Re: [kernel-hardening] [RFC PATCH 1/4] Provide linux/set_memory.h To: Andrew Morton Cc: Daniel Borkmann , Michael Ellerman , "kernel-hardening@lists.openwall.com" , LKML , Laura Abbott Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1317 Lines: 39 On Thu, Jun 29, 2017 at 2:03 AM, Daniel Borkmann wrote: > On 06/29/2017 08:29 AM, Michael Ellerman wrote: >> >> Currently code that wants to use set_memory_ro() etc, needs to include >> asm/set_memory.h, which doesn't exist on all arches. Some code knows >> it only builds on arches which have the header, other code guards the >> inclusion with an #ifdef, neither is ideal. >> >> So create linux/set_memory.h. This always exists, so users don't need >> an #ifdef just to include the header. >> >> When CONFIG_ARCH_HAS_SET_MEMORY=y it includes asm/set_memory.h, >> otherwise it provides empty non-failing implementations. >> >> Signed-off-by: Michael Ellerman > > > Looks good to me, thanks! > > Acked-by: Daniel Borkmann > > I'm fine if Andrew or Kees picks up the bpf patch as well, I think > there shouldn't be any conflict with net-next on this one (and even > if so, then looks trivial to resolve). I nominate Andrew. ;) This should go in early in the merge window and the users can go late in the window. If Andrew has enough to do, I can carry it too; just say the word. This is a sane addition and allows for lines-of-code reduction in a few places. Thanks! Acked-by: Kees Cook -Kees -- Kees Cook Pixel Security