Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752763AbdF2QUx (ORCPT ); Thu, 29 Jun 2017 12:20:53 -0400 Received: from mx2.suse.de ([195.135.220.15]:59643 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751669AbdF2QUq (ORCPT ); Thu, 29 Jun 2017 12:20:46 -0400 Date: Thu, 29 Jun 2017 18:20:44 +0200 Message-ID: From: Takashi Iwai To: "Arvind Yadav" Cc: , , Subject: Re: [PATCH] ALSA: hda: constify attribute_group structures. In-Reply-To: References: User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.2 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 654 Lines: 21 On Thu, 29 Jun 2017 12:37:01 +0200, Arvind Yadav wrote: > > attribute_groups are not supposed to change at runtime. All functions > working with attribute_groups provided by work with const > attribute_group. So mark the non-const structs as const. > > File size before: > text data bss dec hex filename > 995 608 0 1603 643 sound/pci/hda/hda_sysfs.o > > File size After adding 'const': > text data bss dec hex filename > 1035 544 0 1579 62b sound/pci/hda/hda_sysfs.o > > Signed-off-by: Arvind Yadav Applied, thanks. Takashi