Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752733AbdF2QbZ (ORCPT ); Thu, 29 Jun 2017 12:31:25 -0400 Received: from mail-cys01nam02on0094.outbound.protection.outlook.com ([104.47.37.94]:57024 "EHLO NAM02-CY1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752343AbdF2QbR (ORCPT ); Thu, 29 Jun 2017 12:31:17 -0400 From: Matthew Wilcox To: Linus Torvalds , Thomas Gleixner CC: Greg KH , "Luis R. Rodriguez" , "mfuzzey@parkeon.com" , "Eric W. Biederman" , Dmitry Torokhov , Daniel Wagner , David Woodhouse , "jewalt@lgsinnovations.com" , "rafal@milecki.pl" , "Arend Van Spriel" , "Rafael J. Wysocki" , "Li, Yi" , "atull@kernel.org" , Moritz Fischer , Petr Mladek , Johannes Berg , "Emmanuel Grumbach" , "Coelho, Luciano" , Kalle Valo , "Andrew Lutomirski" , Kees Cook , "AKASHI, Takahiro" , David Howells , Peter Jones , Hans de Goede , "Alan Cox" , "Theodore Ts'o" , Michael Kerrisk , Paul Gortmaker , Marcelo Tosatti , Linux API , linux-fsdevel , Linux Kernel Mailing List , "stable # 4 . 6" Subject: RE: [PATCH 2/4] swait: add the missing killable swaits Thread-Topic: [PATCH 2/4] swait: add the missing killable swaits Thread-Index: AQHS5Vx9zvfEAWeC70arwBzTLI3JfaI74tcAgAADLwCAAAhnAIAAAxSAgAApEICAAAPhwA== Date: Thu, 29 Jun 2017 16:31:08 +0000 Message-ID: References: <20170614222017.14653-1-mcgrof@kernel.org> <20170614222017.14653-3-mcgrof@kernel.org> <20170629125402.GH26046@kroah.com> <20170629133530.GA14747@kroah.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=True; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Ref=https://api.informationprotection.azure.com/api/72f988bf-86f1-41af-91ab-2d7cd011db47; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Owner=mawilcox@microsoft.com; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2017-06-29T12:31:06.4144530-04:00; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Name=General; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Application=Microsoft Azure Information Protection; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Extended_MSFT_Method=Automatic; Sensitivity=General authentication-results: linux-foundation.org; dkim=none (message not signed) header.d=none;linux-foundation.org; dmarc=none action=none header.from=microsoft.com; x-originating-ip: [167.220.1.68] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;BY2PR21MB0035;7:72ihVpY33kx9j4Gygxs06xrHAc9rUYx/bcyhGdyVLFXhzxU5Qay1KYdDdiB1sUa8d6WAmoFazjdje3LKvu1oz9y9yFpYvF8gGPkZiuPcaIJIhdXKAJHHIeaDFJH56HUcgTN8XFnENp34oT1fvtyPD8I3rr0riUAmPK6K/pldW5X+Ei3rZfp+wwlLRhlB4UeUeWgDMxbquWZ48EguEvNPDJL8fqeqCSWnxuJ0XGUPTFIC4/rFdxZ6t6DvPSj5bccB/YqHQblTgFic87x7Ius/SSOcb314kmzOr6E/cZO3YqPDymo70+GvN1WdszWFznAo9uomPz/zFVeb6RutYRshCetehGOhwL0YP63Q4++EIoqURnp7V6eTxndh6yplZt4eX6fBZD/jXTbVA3vWF0ckhYa0oOJW0XYuMQAj89umG4/nkOWU7qTxi2coG82cnNjzopZ8EeOWofVa3NTRaEb9hllqlL7UGq4h+r2HgSI0DxTnalI1BSxINeWcJoiWUPOsa2gur4wwy8dSTZnh+cPitDhNwdXY6WrjJxPYkBg2ZNNHVoLuse5Up10GUIl/3ZfLRq+9sLWxqU3x9mAe/hV+Z8IJODYCzGUXVHpi/Crl4Bxh0O9qOaMQctJVhflkoyZeMBOTr6535H3SLM/4k3e73x85nerALG9mFZd3Z0B/agT+3IzNLAU9F02wOrD2eLhm4utv9Xrj/n4jIPeCosfWJozqX9AeXZ7MM16Ler3Yi9NXt1e2082Dn2E6QOiTwA6gI/nSHnfxDRvAis38RMK8lLmkjseTVxHL8fK6GfADhBdJ/F0gijeY8GGwdeGO20Tc x-ms-office365-filtering-correlation-id: d6bae375-dca9-4b94-f916-08d4bf0c3f4b x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254075)(300000503095)(300135400095)(48565401081)(2017052603024)(201703131423075)(201703031133081)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);SRVR:BY2PR21MB0035; x-ms-traffictypediagnostic: BY2PR21MB0035: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(236129657087228)(247924648384137); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(61425038)(6040450)(601004)(2401047)(2017060910016)(8121501046)(5005006)(100000703101)(100105400095)(10201501046)(93006095)(93001095)(3002001)(6055026)(61426038)(61427038)(6041248)(20161123555025)(20161123562025)(20161123560025)(20161123558100)(20161123564025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(6072148)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:BY2PR21MB0035;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:BY2PR21MB0035; x-forefront-prvs: 0353563E2B x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(39400400002)(39410400002)(39860400002)(39450400003)(39850400002)(39840400002)(24454002)(8936002)(3660700001)(478600001)(76176999)(53936002)(6506006)(6436002)(5005710100001)(14454004)(10090500001)(305945005)(3280700002)(74316002)(7736002)(50986999)(86612001)(2900100001)(55016002)(99286003)(54906002)(9686003)(86362001)(2906002)(189998001)(54356999)(81166006)(8676002)(93886004)(5660300001)(7406005)(33656002)(7416002)(3846002)(106356001)(7696004)(10290500003)(6246003)(39060400002)(8990500004)(2950100002)(6116002)(102836003)(38730400002)(66066001)(25786009)(4326008)(77096006)(229853002);DIR:OUT;SFP:1102;SCL:1;SRVR:BY2PR21MB0035;H:BY2PR21MB0036.namprd21.prod.outlook.com;FPR:;SPF:None;MLV:ovrnspm;PTR:InfoNoRecords;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Jun 2017 16:31:08.6147 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2PR21MB0035 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id v5TGVV3T014618 Content-Length: 408 Lines: 13 Linus Torvalds wrote: > The thing is simply a collection of small hacks and should NOT be used > in general. > > I never want to see a driver use that code, for example. It was > designed for RCU and RT, and it should damn well be limited to that. Maybe put #ifndef MODULE around the entire include file then? And definitely remove this line: * One would recommend using this wait queue where possible.