Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752836AbdF2RGF (ORCPT ); Thu, 29 Jun 2017 13:06:05 -0400 Received: from resqmta-ch2-10v.sys.comcast.net ([69.252.207.42]:58364 "EHLO resqmta-ch2-10v.sys.comcast.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751333AbdF2RF5 (ORCPT ); Thu, 29 Jun 2017 13:05:57 -0400 Date: Thu, 29 Jun 2017 12:05:50 -0500 (CDT) From: Christoph Lameter X-X-Sender: cl@east.gentwo.org To: Kees Cook cc: Andrew Morton , Laura Abbott , Daniel Micay , Pekka Enberg , David Rientjes , Joonsoo Kim , "Paul E. McKenney" , Ingo Molnar , Josh Triplett , Andy Lutomirski , Nicolas Pitre , Tejun Heo , Daniel Mack , Sebastian Andrzej Siewior , Sergey Senozhatsky , Helge Deller , Rik van Riel , LKML , Linux-MM , "kernel-hardening@lists.openwall.com" Subject: Re: [PATCH v2] mm: Add SLUB free list pointer obfuscation In-Reply-To: Message-ID: References: <20170623015010.GA137429@beast> Content-Type: text/plain; charset=US-ASCII X-CMAE-Envelope: MS4wfN6WR6R+YTTusXmfDtsCWLAxDOUMnCysWlZdtba+qZnJDrJAnsxVQuTpcEoB3ScCVtrg0t+Rur6+vLflb7XOTK0J6aQd1KW0kUrflhQjQIAlTxipavds hg5RkX0Pwzl94pV1FyKOIMr5x2zQILapcDy4PF5v0kJycN6WaVF10snFSv29i6EmOc2YKF+1mWzLuB40VfCfdHYlpoAE2QqMB2DyR1OQrm5d3E0BqKuiFDzw fSRskX3YhV8R4cZze4ZiRf2FxKWG07sfct3xG7ZP7GBXjcBpUANSB9duHFJBp0U+3UUfUOnubHlLYgFV6hbcZ5RrMXfnKoQqzeUEgJbrbrYUW9Z9HyVKkhzl xkHPOs3T5L5nqq459Vd+tgAz2cB5wQWB1J0AD46chUoQWFrnX0c1Lkr49pGMn2zIvLT3wYEnqJ/CkzN/d5eMz/+hBq5qAkOiqN8srZA1KJXkpcnyEtg2t2Vg 6hCa47MmpLFcMehtF0sm1Hz9fSVgH66n9LZnt5saTVJW95OgYgl8+kvbwIhh2ZXIxzzYvYwzqdNR2R90ObQqLt0lO/TIsT1Khlw/kQsqkk+AR/t080qLeQ7g yHLmHri+7ReSzeiO8MAe54/EvAh2/Wj/c8DtDDX2kJGimhmsFgtTAmiQwQFc73j0534if/H3WNbPb6Q+RAUQYej4DEiZVKkw+zblEXyfhKclq2CEoC8Zd19s LN8xlEXBKXqzpp4XWFVxs7zdLyJ4XsNE5vIMlj4KQOCpt8e9uLrbgjf/1oJQO8p9h4TsdWLCBD2dp2uEr3AWQbCl8O3bAhTzDlf5m7fW8TCi9v1fwZ1mpQ== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 420 Lines: 9 On Sun, 25 Jun 2017, Kees Cook wrote: > The difference gets lost in the noise, but if the above is sensible, > it's 0.07% slower. ;) Hmmm... These differences add up. Also in a repetative benchmark like that you do not see the impact that the additional cacheline use in the cpu cache has on larger workloads. Those may be pushed over the edge of l1 or l2 capacity at some point which then causes drastic regressions.