Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753291AbdF2RSw (ORCPT ); Thu, 29 Jun 2017 13:18:52 -0400 Received: from conssluserg-05.nifty.com ([210.131.2.90]:25746 "EHLO conssluserg-05.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751936AbdF2RSh (ORCPT ); Thu, 29 Jun 2017 13:18:37 -0400 DKIM-Filter: OpenDKIM Filter v2.10.3 conssluserg-05.nifty.com v5THIWIq003872 X-Nifty-SrcIP: [209.85.161.173] MIME-Version: 1.0 In-Reply-To: <51221840-b08e-45f1-5601-937fb15f3947@suse.de> References: <20170625170020.11791-1-afaerber@suse.de> <20170625170020.11791-4-afaerber@suse.de> <20170628164605.2gnvrv4g7jluzyrm@rob-hp-laptop> <51221840-b08e-45f1-5601-937fb15f3947@suse.de> From: Masahiro Yamada Date: Fri, 30 Jun 2017 02:18:31 +0900 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 3/5] dt-bindings: arm: Document Socionext MB86S71 and Fujitsu F-Cue To: =?UTF-8?Q?Andreas_F=C3=A4rber?= Cc: Rob Herring , linux-arm-kernel , Linux Kernel Mailing List , Satoru OKAMOTO , Mark Rutland , devicetree@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id v5THJ3qa023115 Content-Length: 3219 Lines: 92 Hi Andreas, 2017-06-29 21:53 GMT+09:00 Andreas Färber : > Hi Masahiro-san, > > Am 29.06.2017 um 14:18 schrieb Masahiro Yamada: >> 2017-06-29 1:46 GMT+09:00 Rob Herring : >>> On Sun, Jun 25, 2017 at 07:00:18PM +0200, Andreas Färber wrote: >>>> For consistency with existing SoC bindings, use "fujitsu,mb86s71" but >>>> socionext.txt. >>>> >>>> Signed-off-by: Andreas Färber >>>> --- >>>> Documentation/devicetree/bindings/arm/socionext.txt | 17 +++++++++++++++++ >>>> 1 file changed, 17 insertions(+) >>>> create mode 100644 Documentation/devicetree/bindings/arm/socionext.txt >>> >>> Acked-by: Rob Herring >>> -- >> >> I do not mind this, but >> please note there are multiple product lines in Socionext >> because Socionext merged LSI divisions from Panasonic and Fujitsu. >> >> I maintain documents for Socionext UniPhier SoC family >> (which inherits SoC architecture of Panasonic) >> in Documentation/devicetree/bindings/arm/uniphier/. > > Actually you seemed to be lacking bindings beyond the cache controller > for Uniphier: > > https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/Documentation/devicetree/bindings/arm/uniphier > > The SoC compatible, e.g. "socionext,uniphier-ld11", needs to be defined > somewhere too, as done here. A git-grep for that particular compatible > only finds derived clk and reset bindings. I can care to send a patch later, but it is off-topic here. > Using socionext.txt allows you to add those bindings to a shared file; > if you prefer to host them separately below uniphier/ or as uniphier.txt I was thinking of this way. For example, TI has omap/, keystone/, davinci.txt, etc. in this directory level. > do you have a better name suggestion for this one? I was trying to keep > our options open to later add SC2A11 in socionext.txt, and I also saw > some mb8ac300 or so (MB86S7x predecessor?) in downstream sources, so I > don't know a good common name for the non-Panasonic parts. And if we > take fujitsu.txt for MB86S7x to match the vendor prefix then we will > need a separate file for the new SC2A11 IIUC. I have no idea. Actually, I am not familiar with those SoCs. I am not sure if there exists a common name for those Fujitsu-derived SoCs. I think a SoC family name will be helpful to avoid proliferating arch/arm/mach-{mb86s7x,mb8ac300, ...}. I see some Socionext guys CC'ed in this mail, somebody might have information about this. As I said before, I do not mind adding socionext.txt and it seems reasonable enough if there is no common name for those SoCs. > Also if you can tell us where the cut between Fujitsu and Socionext > should be done, we can certainly adapt. NXP is still adding all their > new SoCs in fsl.txt, it seems. > (A similar naming issue exists for my not-yet-submitted FM4 patches, > where it changed owners from Fujitsu to Spansion and then to Cypress.) > Right, vendor names are not future-proof in some cases. We use "uniphier" because it is convenient to make a group of SoCs with similar architecture, and it will work even if UniPhier product lines are sold again in the future. :-) -- Best Regards Masahiro Yamada