Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751896AbdF2TtH (ORCPT <rfc822;w@1wt.eu>);
        Thu, 29 Jun 2017 15:49:07 -0400
Received: from mail.kernel.org ([198.145.29.99]:54778 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751532AbdF2TtG (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 29 Jun 2017 15:49:06 -0400
DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 62F6C22BE2
Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org
Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=mcgrof@kernel.org
MIME-Version: 1.0
In-Reply-To: <20170629190854.GE3954@linux-80c1.suse>
References: <20170623233702.20564-1-jakub.kicinski@netronome.com>
 <CA+55aFxivLtaFEur99eZpoafcweK1WNvSu2vEvxXvj5gKB8CdA@mail.gmail.com>
 <20170626233030.GI21846@wotan.suse.de> <CA+55aFzjrGsFvt56YPo-1tN7ZEPPANaO5ZVNxUS18JAiHdz83g@mail.gmail.com>
 <20170627001534.GK21846@wotan.suse.de> <20170629190854.GE3954@linux-80c1.suse>
From: "Luis R. Rodriguez" <mcgrof@kernel.org>
Date: Thu, 29 Jun 2017 12:48:43 -0700
X-Gmail-Original-Message-ID: <CAB=NE6VSR2Q38xz8vCUNsgUAo770_5pDZy04yZ5LpOCvum0FUg@mail.gmail.com>
Message-ID: <CAB=NE6VSR2Q38xz8vCUNsgUAo770_5pDZy04yZ5LpOCvum0FUg@mail.gmail.com>
Subject: Re: [PATCH] firmware: wake all waiters
To: Davidlohr Bueso <dave@stgolabs.net>,
        Matthew Wilcox <mawilcox@microsoft.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Peter Zijlstra <peterz@infradead.org>, DanielWagnerwagi@monom.org,
        Boqun Feng <boqun.feng@gmail.com>,
        Marcelo Tosatti <mtosatti@redhat.com>,
        Paul Gortmaker <paul.gortmaker@windriver.com>,
        Ming Lei <ming.lei@redhat.com>, "Li, Yi" <yi1.li@linux.intel.com>,
        "AKASHI, Takahiro" <takahiro.akashi@linaro.org>,
        Jakub Kicinski <jakub.kicinski@netronome.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        "Eric W. Biederman" <ebiederm@xmission.com>,
        Petr Mladek <pmladek@suse.com>, Andrew Lutomirski <luto@kernel.org>,
        Kees Cook <keescook@chromium.org>, David Howells <dhowells@redhat.com>,
        Alan Cox <alan@linux.intel.com>, "Theodore Ts'o" <tytso@mit.edu>,
        oss-drivers@netronome.com
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 723
Lines: 21

On Thu, Jun 29, 2017 at 12:08 PM, Davidlohr Bueso <dave@stgolabs.net> wrote:
> On Tue, 27 Jun 2017, Luis R. Rodriguez wrote:
>>
>>  * As a side effect of this; the data structures are slimmer.
>>  *
>> - * One would recommend using this wait queue where possible.
>> + * NOTE: swait is for cases of extreme memory considerations and some
>> very
>> + * special realtime issues, where it saves a couple of bytes in
>> structures that
>> + * need close packing. As such its very special-use. Consider using
>> regular
>> + * waits queues from wait.h instead *first*.
>
>
> How about the following?

And do we want to make it even more *special-use* by wrapping it with
#ifndef MODULE as suggested by Matthew Wilcox ?

  Luis