Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753269AbdF2Ttm (ORCPT ); Thu, 29 Jun 2017 15:49:42 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:45192 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752475AbdF2Ttk (ORCPT ); Thu, 29 Jun 2017 15:49:40 -0400 Date: Thu, 29 Jun 2017 15:49:37 -0400 (EDT) Message-Id: <20170629.154937.1428574116488487036.davem@davemloft.net> To: arvind.yadav.cs@gmail.com Cc: benh@kernel.crashing.org, paulus@samba.org, mpe@ellerman.id.au, tlfalcon@linux.vnet.ibm.com, linuxppc-dev@lists.ozlabs.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: ibm: ibmveth: constify dev_pm_ops structures. From: David Miller In-Reply-To: <24303710c4e099faa0ca7d9d92a71e53d6b66bcc.1498714986.git.arvind.yadav.cs@gmail.com> References: <24303710c4e099faa0ca7d9d92a71e53d6b66bcc.1498714986.git.arvind.yadav.cs@gmail.com> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 29 Jun 2017 12:07:53 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 664 Lines: 18 From: Arvind Yadav Date: Thu, 29 Jun 2017 11:14:50 +0530 > dev_pm_ops are not supposed to change at runtime. All functions > working with dev_pm_ops provided by work with const > dev_pm_ops. So mark the non-const structs as const. > > File size before: > text data bss dec hex filename > 15426 1256 0 16682 412a drivers/net/ethernet/ibm/ibmveth.o > > File size After adding 'const': > text data bss dec hex filename > 15618 1064 0 16682 412a drivers/net/ethernet/ibm/ibmveth.o > > Signed-off-by: Arvind Yadav Applied.