Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753424AbdF2TuE (ORCPT ); Thu, 29 Jun 2017 15:50:04 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:45220 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753288AbdF2TuC (ORCPT ); Thu, 29 Jun 2017 15:50:02 -0400 Date: Thu, 29 Jun 2017 15:49:50 -0400 (EDT) Message-Id: <20170629.154950.722057525346376563.davem@davemloft.net> To: arvind.yadav.cs@gmail.com Cc: claudiu.manoil@freescale.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: freescale: gianfar : constify dev_pm_ops structures. From: David Miller In-Reply-To: <8a8554d003a6e7bb2435d55258a9120eb5822a82.1498715654.git.arvind.yadav.cs@gmail.com> References: <8a8554d003a6e7bb2435d55258a9120eb5822a82.1498715654.git.arvind.yadav.cs@gmail.com> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 29 Jun 2017 12:08:05 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 676 Lines: 18 From: Arvind Yadav Date: Thu, 29 Jun 2017 11:26:06 +0530 > dev_pm_ops are not supposed to change at runtime. All functions > working with dev_pm_ops provided by work with const > dev_pm_ops. So mark the non-const structs as const. > > File size before: > text data bss dec hex filename > 19057 392 0 19449 4bf9 drivers/net/ethernet/freescale/gianfar.o > > File size After adding 'const': > text data bss dec hex filename > 19249 192 0 19441 4bf1 drivers/net/ethernet/freescale/gianfar.o > > Signed-off-by: Arvind Yadav Applied.