Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753268AbdF2UFS convert rfc822-to-8bit (ORCPT ); Thu, 29 Jun 2017 16:05:18 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:45536 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751661AbdF2UFQ (ORCPT ); Thu, 29 Jun 2017 16:05:16 -0400 Date: Thu, 29 Jun 2017 16:05:13 -0400 (EDT) Message-Id: <20170629.160513.1064622973584891732.davem@davemloft.net> To: clabbe.montjoie@gmail.com Cc: robh+dt@kernel.org, mark.rutland@arm.com, linux@armlinux.org.uk, maxime.ripard@free-electrons.com, wens@csie.org, peppe.cavallaro@st.com, alexandre.torgue@st.com, andre.przywara@arm.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-sunxi@googlegroups.com Subject: Re: [PATCH 1/6] net: stmmac: support future possible different internal phy mode From: David Miller In-Reply-To: <20170629170238.GA2606@Red> References: <20170627092806.28181-1-clabbe.montjoie@gmail.com> <20170629.122349.2265868886957558079.davem@davemloft.net> <20170629170238.GA2606@Red> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=iso-8859-1 Content-Transfer-Encoding: 8BIT X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 29 Jun 2017 12:23:28 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1190 Lines: 29 From: Corentin Labbe Date: Thu, 29 Jun 2017 19:02:38 +0200 > On Thu, Jun 29, 2017 at 12:23:49PM -0400, David Miller wrote: >> From: Corentin Labbe >> Date: Tue, 27 Jun 2017 11:28:01 +0200 >> >> > The current way to find if the phy is internal is to compare DT phy-mode >> > and emac_variant/internal_phy. >> > But it will negate a possible future SoC where an external PHY use the >> > same phy mode than the internal one. >> > >> > By using phy-mode = "internal" we permit to have an external PHY with >> > the same mode than the internal one. >> > >> > Reported-by: Andr? Przywara >> > Signed-off-by: Corentin Labbe >> >> Series applied. >> >> Please provide a proper "[PATCH 0/n] " header posting next time. > > Sorry could you wait for applying, there are a parallel thread (http://www.spinics.net/lists/devicetree/msg183520.html) and it seems finaly that internal could not be the good way to do it. > > Regards > Sorry again, I should have sent a comment for waiting. Please send me a revert patch, when I say I've applied it I already pushed it out to my GIT tree.