Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753528AbdF2VhP (ORCPT ); Thu, 29 Jun 2017 17:37:15 -0400 Received: from mail-pf0-f170.google.com ([209.85.192.170]:34800 "EHLO mail-pf0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751896AbdF2VhN (ORCPT ); Thu, 29 Jun 2017 17:37:13 -0400 Date: Thu, 29 Jun 2017 14:37:07 -0700 From: Bjorn Andersson To: Stephen Boyd Cc: Rob Clark , linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org Subject: Re: [PATCH] spmi: Include OF based modalias in device uevent Message-ID: <20170629213707.GB18666@tuxbook> References: <20170628234458.7917-1-bjorn.andersson@linaro.org> <20170629210449.GC22780@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170629210449.GC22780@codeaurora.org> User-Agent: Mutt/1.8.2 (2017-04-18) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 757 Lines: 23 On Thu 29 Jun 14:04 PDT 2017, Stephen Boyd wrote: > On 06/28, Bjorn Andersson wrote: > > Include the OF-based modalias in the uevent sent when registering SPMI > > devices, so that user space has a chance to autoload the kernel module > > for the device. > > > > Reported-by: Rob Clark > > Signed-off-by: Bjorn Andersson > > --- > > Reviewed-by: Stephen Boyd > > I suppose we can delete the MODALIAS in the qcom-spmi-pmic file > too? That doesn't look like it could ever work > Right, it has never worked. Potentially we would like some SPMI based modalias thing, but I'm not sure we have enough information about the found device to create a meaningful alias. Regards, Bjorn