Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751656AbdF2WcJ (ORCPT ); Thu, 29 Jun 2017 18:32:09 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:39646 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751420AbdF2WcI (ORCPT ); Thu, 29 Jun 2017 18:32:08 -0400 Date: Thu, 29 Jun 2017 15:32:06 -0700 From: Andrew Morton To: Alexander Potapenko Cc: dvyukov@google.com, kcc@google.com, davem@davemloft.net, linux-kernel@vger.kernel.org, Mateusz Jurczyk Subject: Re: [PATCH] sysctl: don't read uninit memory in deprecated_sysctl_warning() Message-Id: <20170629153206.73185df8e314efb232bf77b0@linux-foundation.org> In-Reply-To: <20170628150037.3809-1-glider@google.com> References: <20170628150037.3809-1-glider@google.com> X-Mailer: Sylpheed 3.4.1 (GTK+ 2.24.23; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 383 Lines: 9 On Wed, 28 Jun 2017 17:00:37 +0200 Alexander Potapenko wrote: > Don't attempt to read the first two elements of name[] unless they > were actually copied from the userspace. > > This bug has been detected by KMSAN. Thanks. I already have the identical http://ozlabs.org/~akpm/mmots/broken-out/sysctl-check-name-array-length-in-deprecated_sysctl_warning.patch