Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751867AbdF2XR5 (ORCPT ); Thu, 29 Jun 2017 19:17:57 -0400 Received: from mail.kernel.org ([198.145.29.99]:48200 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751776AbdF2XRz (ORCPT ); Thu, 29 Jun 2017 19:17:55 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 70C2522BE4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=robh+dt@kernel.org MIME-Version: 1.0 In-Reply-To: <1498664922-28493-4-git-send-email-aleksandar.markovic@rt-rk.com> References: <1498664922-28493-1-git-send-email-aleksandar.markovic@rt-rk.com> <1498664922-28493-4-git-send-email-aleksandar.markovic@rt-rk.com> From: Rob Herring Date: Thu, 29 Jun 2017 18:17:33 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 03/10] Documentation: Add device tree binding for Goldfish PIC driver To: Aleksandar Markovic Cc: Linux-MIPS , Aleksandar Markovic , Miodrag Dinic , Goran Ferenc , "David S. Miller" , "devicetree@vger.kernel.org" , Douglas Leung , Greg Kroah-Hartman , James Hogan , Jason Cooper , "linux-kernel@vger.kernel.org" , Marc Zyngier , Mark Rutland , "Martin K. Petersen" , Mauro Carvalho Chehab , Paul Burton , Petar Jovanovic , Raghu Gandham , Thomas Gleixner Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 644 Lines: 17 On Wed, Jun 28, 2017 at 10:46 AM, Aleksandar Markovic wrote: > From: Aleksandar Markovic > > Add documentation for DT binding of Goldfish PIC driver. The compatible > string used by OS for binding the driver is "google,goldfish-pic". This isn't even supported in Google's common kernel tree. If it's not important enough for it, why should it be for mainline kernel? To put it another way, why does goldfish need a special interrupt controller. Just use one of the many that are already supported in the kernel and emulated by qemu. Same comments apply to the RTC patch. Rob