Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751890AbdF3BnK (ORCPT ); Thu, 29 Jun 2017 21:43:10 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:35976 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751601AbdF3BnI (ORCPT ); Thu, 29 Jun 2017 21:43:08 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 4A5F66086D Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=sboyd@codeaurora.org Date: Thu, 29 Jun 2017 18:43:05 -0700 From: Stephen Boyd To: Chunyan Zhang Cc: Chunyan Zhang , Michael Turquette , Rob Herring , Mark Rutland , linux-clk@vger.kernel.org, "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Arnd Bergmann , Mark Brown , Xiaolong Zhang , Orson Zhai , Geng Ren , Ben Li Subject: Re: [PATCH V1 3/9] clk: sprd: add gate clock support Message-ID: <20170630014305.GK22780@codeaurora.org> References: <20170618015855.27738-1-chunyan.zhang@spreadtrum.com> <20170618015855.27738-4-chunyan.zhang@spreadtrum.com> <20170620013130.GI4493@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 981 Lines: 26 On 06/22, Chunyan Zhang wrote: > On 20 June 2017 at 09:31, Stephen Boyd wrote: > > On 06/18, Chunyan Zhang wrote: > >> diff --git a/drivers/clk/sprd/Makefile b/drivers/clk/sprd/Makefile > >> index 8f802b2..333e2b2 100644 > >> --- a/drivers/clk/sprd/Makefile > >> +++ b/drivers/clk/sprd/Makefile > >> @@ -1,3 +1,3 @@ > >> ifneq ($(CONFIG_OF),) > >> -obj-y += ccu_common.o > >> +obj-y += ccu_common.o ccu_gate.o > > > > Can this be built as a module? > > Since most of all Spreadtrum device drivers would depend on if clocks > have been initialized, so we'd prefer to build this into the kernel > image. This isn't really a good reason, but OK. Hopefully nobody wants to make a module for every driver on the system and jam the ones needed to access the rootfs into a ramdisk. Don't worry, you don't need to support modules here. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project