Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752059AbdF3BnV (ORCPT ); Thu, 29 Jun 2017 21:43:21 -0400 Received: from ozlabs.org ([103.22.144.67]:58933 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751701AbdF3BnU (ORCPT ); Thu, 29 Jun 2017 21:43:20 -0400 From: Michael Ellerman To: Kees Cook , Andrew Morton Cc: Daniel Borkmann , "kernel-hardening\@lists.openwall.com" , LKML , Laura Abbott Subject: Re: [kernel-hardening] [RFC PATCH 1/4] Provide linux/set_memory.h In-Reply-To: References: <1498717781-29151-1-git-send-email-mpe@ellerman.id.au> <5954C262.9000502@iogearbox.net> User-Agent: Notmuch/0.21 (https://notmuchmail.org) Date: Fri, 30 Jun 2017 11:43:18 +1000 Message-ID: <87d19mqmh5.fsf@concordia.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1375 Lines: 37 Kees Cook writes: > On Thu, Jun 29, 2017 at 2:03 AM, Daniel Borkmann wrote: >> On 06/29/2017 08:29 AM, Michael Ellerman wrote: >>> >>> Currently code that wants to use set_memory_ro() etc, needs to include >>> asm/set_memory.h, which doesn't exist on all arches. Some code knows >>> it only builds on arches which have the header, other code guards the >>> inclusion with an #ifdef, neither is ideal. >>> >>> So create linux/set_memory.h. This always exists, so users don't need >>> an #ifdef just to include the header. >>> >>> When CONFIG_ARCH_HAS_SET_MEMORY=y it includes asm/set_memory.h, >>> otherwise it provides empty non-failing implementations. >>> >>> Signed-off-by: Michael Ellerman >> >> >> Looks good to me, thanks! >> >> Acked-by: Daniel Borkmann >> >> I'm fine if Andrew or Kees picks up the bpf patch as well, I think >> there shouldn't be any conflict with net-next on this one (and even >> if so, then looks trivial to resolve). > > I nominate Andrew. ;) This should go in early in the merge window and > the users can go late in the window. If Andrew has enough to do, I can > carry it too; just say the word. > > This is a sane addition and allows for lines-of-code reduction in a > few places. Thanks! Andrew's picked them up in mmotm, thanks everyone. cheers