Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751951AbdF3DS6 (ORCPT <rfc822;w@1wt.eu>);
        Thu, 29 Jun 2017 23:18:58 -0400
Received: from mga02.intel.com ([134.134.136.20]:20200 "EHLO mga02.intel.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751784AbdF3DS4 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 29 Jun 2017 23:18:56 -0400
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.40,284,1496127600"; 
   d="scan'208";a="873301754"
Date: Thu, 29 Jun 2017 20:18:49 -0700
From: Andi Kleen <ak@linux.intel.com>
To: Yinghai Lu <yinghai@kernel.org>
Cc: Stephane Eranian <eranian@google.com>,
        "H. Peter Anvin" <hpa@zytor.com>, Ingo Molnar <mingo@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>, Borislav Petkov <bp@alien8.de>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Bjorn Helgaas <helgaas@kernel.org>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Matthew Wilcox <willy@linux.intel.com>,
        Ivan Kokshaysky <ink@jurassic.park.msu.ru>,
        "linux-tip-commits@vger.kernel.org" 
        <linux-tip-commits@vger.kernel.org>
Subject: Re: [tip:x86/platform] x86/PCI/mmcfg: Switch to ECAM config mode if
 possible
Message-ID: <20170630031849.GP23705@tassilo.jf.intel.com>
References: <20170316215057.452220163@linutronix.de>
 <tip-b5b0f00c760b6e9673ab79b88ede2f3c7a039f74@git.kernel.org>
 <CAE9FiQVAqZRtMLKTtySaCiCbDicN0h=6dPXEGP1M2eAq9AiYXQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAE9FiQVAqZRtMLKTtySaCiCbDicN0h=6dPXEGP1M2eAq9AiYXQ@mail.gmail.com>
User-Agent: Mutt/1.8.0 (2017-02-23)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1179
Lines: 31

> Hi Thomas,
> 
> Would this patch actually void the commit:

Yes it does. My origina; patches were opt-in for this reason, but Thomas doesn't
believe in historical or other people's experience.

But MCFG problems were a long time ago and noone uses these systems anymore,
so perhaps he is right.

-Andi

> 
> commit a0ca9909609470ad779b9b9cc68ce96e975afff7
> Author: Ivan Kokshaysky <ink@jurassic.park.msu.ru>
> Date:   Mon Jan 14 17:31:09 2008 -0500
> 
>     PCI x86: always use conf1 to access config space below 256 bytes
> 
>     Thanks to Loic Prylli <loic@myri.com>, who originally proposed
>     this idea.
> 
>     Always using legacy configuration mechanism for the legacy config space
>     and extended mechanism (mmconf) for the extended config space is
>     a simple and very logical approach. It's supposed to resolve all
>     known mmconf problems. It still allows per-device quirks (tweaking
>     dev->cfg_size). It also allows to get rid of mmconf fallback code.
> 
>     Signed-off-by: Ivan Kokshaysky <ink@jurassic.park.msu.ru>
>     Signed-off-by: Matthew Wilcox <willy@linux.intel.com>
>     Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>