Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751854AbdF3F2m (ORCPT ); Fri, 30 Jun 2017 01:28:42 -0400 Received: from mail-pg0-f66.google.com ([74.125.83.66]:35850 "EHLO mail-pg0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751333AbdF3F2l (ORCPT ); Fri, 30 Jun 2017 01:28:41 -0400 From: Arvind Yadav To: swhiteho@redhat.com, rpeterso@redhat.com, torvalds@linux-foundation.org Cc: cluster-devel@redhat.com, linux-kernel@vger.kernel.org Subject: [PATCH] fs: GFS2: constify attribute_group structures. Date: Fri, 30 Jun 2017 10:58:30 +0530 Message-Id: X-Mailer: git-send-email 1.9.1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1136 Lines: 38 attribute_groups are not supposed to change at runtime. All functions working with attribute_groups provided by work with const attribute_group. So mark the non-const structs as const. File size before: text data bss dec hex filename 5259 1344 8 6611 19d3 fs/gfs2/sys.o File size After adding 'const': text data bss dec hex filename 5371 1216 8 6595 19c3 fs/gfs2/sys.o Signed-off-by: Arvind Yadav --- fs/gfs2/sys.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/gfs2/sys.c b/fs/gfs2/sys.c index 7a51534..01dc027 100644 --- a/fs/gfs2/sys.c +++ b/fs/gfs2/sys.c @@ -637,12 +637,12 @@ static ssize_t tune_set(struct gfs2_sbd *sdp, unsigned int *field, NULL, }; -static struct attribute_group tune_group = { +static const struct attribute_group tune_group = { .name = "tune", .attrs = tune_attrs, }; -static struct attribute_group lock_module_group = { +static const struct attribute_group lock_module_group = { .name = "lock_module", .attrs = lock_module_attrs, }; -- 1.9.1