Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751913AbdF3Fo7 (ORCPT ); Fri, 30 Jun 2017 01:44:59 -0400 Received: from mail-vk0-f65.google.com ([209.85.213.65]:34827 "EHLO mail-vk0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751494AbdF3Fo6 (ORCPT ); Fri, 30 Jun 2017 01:44:58 -0400 MIME-Version: 1.0 In-Reply-To: <20170630044214.GA14004@embeddedgus> References: <20170630044214.GA14004@embeddedgus> From: Frans Klaver Date: Fri, 30 Jun 2017 07:44:56 +0200 Message-ID: Subject: Re: [PATCH] clocksource: em_sti: fix error return codes in em_sti_probe() To: "Gustavo A. R. Silva" Cc: Daniel Lezcano , Thomas Gleixner , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1768 Lines: 42 On Fri, Jun 30, 2017 at 6:42 AM, Gustavo A. R. Silva wrote: > Propagate the return values of platform_get_irq and > devm_request_irq on failure. > > Signed-off-by: Gustavo A. R. Silva > --- > drivers/clocksource/em_sti.c | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --git a/drivers/clocksource/em_sti.c b/drivers/clocksource/em_sti.c > index bc48cbf..c4818dd 100644 > --- a/drivers/clocksource/em_sti.c > +++ b/drivers/clocksource/em_sti.c > @@ -305,7 +305,7 @@ static int em_sti_probe(struct platform_device *pdev) > irq = platform_get_irq(pdev, 0); > if (irq < 0) { > dev_err(&pdev->dev, "failed to get irq\n"); > - return -EINVAL; > + return irq; > } > > /* map memory, let base point to the STI instance */ > @@ -314,11 +314,12 @@ static int em_sti_probe(struct platform_device *pdev) > if (IS_ERR(p->base)) > return PTR_ERR(p->base); > > - if (devm_request_irq(&pdev->dev, irq, em_sti_interrupt, > + irq = devm_request_irq(&pdev->dev, irq, em_sti_interrupt, > IRQF_TIMER | IRQF_IRQPOLL | IRQF_NOBALANCING, > - dev_name(&pdev->dev), p)) { > + dev_name(&pdev->dev), p); > + if (irq) { > dev_err(&pdev->dev, "failed to request low IRQ\n"); > - return -ENOENT; > + return irq; > } This works. Yet I think that 'ret' would be a better candidate for taking the result of devm_request_irq, since it doesn't return the irq number on success. Should someone decide to reference irq at a later point in the code, this has to be changed.