Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751934AbdF3GB6 (ORCPT ); Fri, 30 Jun 2017 02:01:58 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:43176 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751792AbdF3GB5 (ORCPT ); Fri, 30 Jun 2017 02:01:57 -0400 Date: Fri, 30 Jun 2017 08:01:20 +0200 From: Greg Kroah-Hartman To: Dmitriy Cherkasov Cc: devel@driverdev.osuosl.org, Oleg Drokin , Andreas Dilger , James Simmons , Linux Kernel Mailing List , Lustre Development List Subject: Re: [PATCH v3] staging: lustre: lnet: remove dead code and crc32_le() wrapper Message-ID: <20170630060120.GA29779@kroah.com> References: <1498793366-10539-1-git-send-email-dmitriy@oss-tech.org> <1498794766-12298-1-git-send-email-dmitriy@oss-tech.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1498794766-12298-1-git-send-email-dmitriy@oss-tech.org> User-Agent: Mutt/1.8.3 (2017-05-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 839 Lines: 24 On Fri, Jun 30, 2017 at 03:52:46AM +0000, Dmitriy Cherkasov wrote: > After removing code which was premanently disabled with ifdefs, the > function ksocknal_csum() becomes just a wrapper for crc32_le(). Remove > this useless wrapper and instead call crc32_le() directly. > > This also resolves the following checkpatch warning which was > triggered by the dead code: > > WARNING: space prohibited before semicolon > > Signed-off-by: Dmitriy Cherkasov > --- > drivers/staging/lustre/lnet/klnds/socklnd/socklnd.h | 11 ----------- > drivers/staging/lustre/lnet/klnds/socklnd/socklnd_lib.c | 14 +++++++------- > 2 files changed, 7 insertions(+), 18 deletions(-) What changed from previous versions of this patch? You need to put that information below the --- line, as documented. v4? :) thanks, greg k-h