Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752020AbdF3GC2 (ORCPT ); Fri, 30 Jun 2017 02:02:28 -0400 Received: from mail.kernel.org ([198.145.29.99]:44230 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751866AbdF3GC1 (ORCPT ); Fri, 30 Jun 2017 02:02:27 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 391B322BE7 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=krzk@kernel.org MIME-Version: 1.0 In-Reply-To: References: <20170629213334.375848050@linutronix.de> <20170629214343.882576048@linutronix.de> From: Krzysztof Kozlowski Date: Fri, 30 Jun 2017 08:02:20 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [patch 1/5] pinctrl: samsung: Remove bogus irq_[un]mask from resource management To: Tomasz Figa Cc: Thomas Gleixner , Sylwester Nawrocki , LKML , Marc Zyngier , Linus Walleij , Brian Norris , Heiko Stuebner , linux-rockchip@lists.infradead.org, Julia Cartwright , "linux-gpio@vger.kernel.org" , John Keeping , Doug Anderson , Kukjin Kim , linux-arm-kernel , "linux-samsung-soc@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1086 Lines: 31 On Fri, Jun 30, 2017 at 4:47 AM, Tomasz Figa wrote: > Hi Thomas, > > 2017-06-30 6:33 GMT+09:00 Thomas Gleixner : >> The irq chip callbacks irq_request/release_resources() have absolutely no >> business with masking and unmasking the irq. >> >> The core code unmasks the interrupt after complete setup and masks it >> before invoking irq_release_resources(). >> >> The unmask is actually harmful as it happens before the interrupt is >> completely initialized in __setup_irq(). >> >> Remove it. > > Good catch, thanks! (Note that the original patch of mine [1] did that > in .irq_startup()/.irq_shutdown(), which was for some reason changed > later, but I don't remember the exact story.) > > [1] https://patchwork.kernel.org/patch/4466431/ > > Acked-by: Tomasz Figa > > Sylwester, Krzysztof, would you be able to do some basic test? I suppose this was not tested so yes - I have platforms do this. I understand that checking any non-shared GPIO interrupt should be sufficient to test, right? Best regards, Krzysztof