Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751818AbdF3Hmw (ORCPT ); Fri, 30 Jun 2017 03:42:52 -0400 Received: from gateway33.websitewelcome.com ([192.185.146.195]:17661 "EHLO gateway33.websitewelcome.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751675AbdF3Hmu (ORCPT ); Fri, 30 Jun 2017 03:42:50 -0400 Date: Fri, 30 Jun 2017 02:42:47 -0500 From: "Gustavo A. R. Silva" To: Vinod Koul , Dan Williams , Michal Simek , =?iso-8859-1?Q?S=F6ren?= Brinkmann Cc: dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, "Gustavo A. R. Silva" Subject: [PATCH] dmaengine: zynqmp_dma: fix error return code in zynqmp_dma_chan_probe() Message-ID: <20170630074247.GA26153@embeddedgus> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.23 (2014-03-12) X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 189.152.189.231 X-Exim-ID: 1dQqZj-0037eF-TG X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: (embeddedgus) [189.152.189.231]:48646 X-Source-Auth: garsilva@embeddedor.com X-Email-Count: 32 X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 862 Lines: 28 Print error message and propagate the return value of platform_get_irq on failure. Signed-off-by: Gustavo A. R. Silva --- drivers/dma/xilinx/zynqmp_dma.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/dma/xilinx/zynqmp_dma.c b/drivers/dma/xilinx/zynqmp_dma.c index 6d221e5..5fa6d0d 100644 --- a/drivers/dma/xilinx/zynqmp_dma.c +++ b/drivers/dma/xilinx/zynqmp_dma.c @@ -996,8 +996,11 @@ static int zynqmp_dma_chan_probe(struct zynqmp_dma_device *zdev, zynqmp_dma_init(chan); chan->irq = platform_get_irq(pdev, 0); - if (chan->irq < 0) - return -ENXIO; + if (chan->irq < 0) { + dev_err(&pdev->dev, "failed to get IRQ: %d\n", chan->irq); + return chan->irq; + } + err = devm_request_irq(&pdev->dev, chan->irq, zynqmp_dma_irq_handler, 0, "zynqmp-dma", chan); if (err) -- 2.5.0