Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751813AbdF3HzI (ORCPT ); Fri, 30 Jun 2017 03:55:08 -0400 Received: from gateway22.websitewelcome.com ([192.185.46.187]:40533 "EHLO gateway22.websitewelcome.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751668AbdF3HzH (ORCPT ); Fri, 30 Jun 2017 03:55:07 -0400 Date: Fri, 30 Jun 2017 02:55:03 -0500 From: "Gustavo A. R. Silva" To: Dan Williams , Vinod Koul Cc: dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, "Gustavo A. R. Silva" Subject: [PATCH] dmaengine: zx: add check on platform_get_irq return value Message-ID: <20170630075502.GA27661@embeddedgus> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.23 (2014-03-12) X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 189.152.189.231 X-Exim-ID: 1dQqlc-003HJx-Ei X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: (embeddedgus) [189.152.189.231]:51508 X-Source-Auth: garsilva@embeddedor.com X-Email-Count: 36 X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 730 Lines: 27 Check return value from call to platform_get_irq(), so in case of failure print error message and propagate the return value. Signed-off-by: Gustavo A. R. Silva --- drivers/dma/zx_dma.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/dma/zx_dma.c b/drivers/dma/zx_dma.c index 2bb6953..26196de 100644 --- a/drivers/dma/zx_dma.c +++ b/drivers/dma/zx_dma.c @@ -786,6 +786,11 @@ static int zx_dma_probe(struct platform_device *op) } d->irq = platform_get_irq(op, 0); + if (d->irq < 0) { + dev_err(&op->dev, "failed to get IRQ: %d\n", d->irq); + return d->irq; + } + ret = devm_request_irq(&op->dev, d->irq, zx_dma_int_handler, 0, DRIVER_NAME, d); if (ret) -- 2.5.0