Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751918AbdF3IBZ (ORCPT ); Fri, 30 Jun 2017 04:01:25 -0400 Received: from mail-pg0-f66.google.com ([74.125.83.66]:34131 "EHLO mail-pg0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751494AbdF3IBX (ORCPT ); Fri, 30 Jun 2017 04:01:23 -0400 From: Arvind Yadav To: ericvh@gmail.com, rminnich@sandia.gov, lucho@ionkov.net Cc: v9fs-developer@lists.sourceforge.net, linux-kernel@vger.kernel.org Subject: [PATCH] fs: 9p: v9fs: constify attribute_group structures. Date: Fri, 30 Jun 2017 13:31:10 +0530 Message-Id: <56c6a14b4d05be95e53546d24ef5d2fa56c5e625.1498809585.git.arvind.yadav.cs@gmail.com> X-Mailer: git-send-email 1.9.1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 926 Lines: 32 attribute_groups are not supposed to change at runtime. All functions working with attribute_groups provided by work with const attribute_group. So mark the non-const structs as const. File size before: text data bss dec hex filename 2739 80 28 2847 b1f fs/9p/v9fs.o File size After adding 'const': text data bss dec hex filename 2803 32 28 2863 b2f fs/9p/v9fs.o Signed-off-by: Arvind Yadav --- fs/9p/v9fs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/9p/v9fs.c b/fs/9p/v9fs.c index c202930..d10e6da 100644 --- a/fs/9p/v9fs.c +++ b/fs/9p/v9fs.c @@ -515,7 +515,7 @@ static ssize_t caches_show(struct kobject *kobj, NULL, }; -static struct attribute_group v9fs_attr_group = { +static const struct attribute_group v9fs_attr_group = { .attrs = v9fs_attrs, }; -- 1.9.1