MIME-version: 1.0
Content-transfer-encoding: 8BIT
Content-type: text/plain; charset="UTF-8"
Message-id: <5956057D.3070704@samsung.com>
Date: Fri, 30 Jun 2017 17:02:05 +0900
From: Chanwoo Choi <cw00.choi@samsung.com>
Organization: Samsung Electronics
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101
        Thunderbird/31.6.0
To: "Gustavo A. R. Silva" <garsilva@embeddedor.com>,
        MyungJoo Ham <myungjoo.ham@samsung.com>,
        Kyungmin Park <kyungmin.park@samsung.com>
Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] devfreq: rk3399_dmc: fix error code in
 rk3399_dmcfreq_probe()
In-reply-to: <20170630071522.GA20486@embeddedgus>
CMS-TYPE: 105P
DLP-Filter: Pass
References: <CGME20170630071526epcas3p1104189e06db8f2d62622d72dc5f6fdd6@epcas3p1.samsung.com>
        <20170630071522.GA20486@embeddedgus>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1017
Lines: 34

Hi,

On 2017년 06월 30일 16:15, Gustavo A. R. Silva wrote:
> Print and propagate the return value of platform_get_irq on failure.
> 
> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
> ---
>  drivers/devfreq/rk3399_dmc.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/devfreq/rk3399_dmc.c b/drivers/devfreq/rk3399_dmc.c
> index 40a2499..1b89ebb 100644
> --- a/drivers/devfreq/rk3399_dmc.c
> +++ b/drivers/devfreq/rk3399_dmc.c
> @@ -336,8 +336,9 @@ static int rk3399_dmcfreq_probe(struct platform_device *pdev)
>  
>  	irq = platform_get_irq(pdev, 0);
>  	if (irq < 0) {
> -		dev_err(&pdev->dev, "Cannot get the dmc interrupt resource\n");
> -		return -EINVAL;
> +		dev_err(&pdev->dev,
> +			"Cannot get the dmc interrupt resource: %d\n", irq);
> +		return irq;
>  	}
>  	data = devm_kzalloc(dev, sizeof(struct rk3399_dmcfreq), GFP_KERNEL);
>  	if (!data)
> 

Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>

-- 
Best Regards,
Chanwoo Choi
Samsung Electronics