Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751946AbdF3IcJ (ORCPT ); Fri, 30 Jun 2017 04:32:09 -0400 Received: from mail-wm0-f67.google.com ([74.125.82.67]:35403 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751782AbdF3IcI (ORCPT ); Fri, 30 Jun 2017 04:32:08 -0400 Date: Fri, 30 Jun 2017 10:32:03 +0200 From: Ingo Molnar To: Josh Poimboeuf Cc: x86@kernel.org, linux-kernel@vger.kernel.org, live-patching@vger.kernel.org, Linus Torvalds , Andy Lutomirski , Jiri Slaby , "H. Peter Anvin" , Peter Zijlstra Subject: Re: [PATCH v2 3/8] objtool: stack validation 2.0 Message-ID: <20170630083203.7n5kbwieuoyjoov4@gmail.com> References: <678bd94c0566c6129bcc376cddb259c4c5633004.1498659915.git.jpoimboe@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <678bd94c0566c6129bcc376cddb259c4c5633004.1498659915.git.jpoimboe@redhat.com> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1235 Lines: 30 * Josh Poimboeuf wrote: > This is a major rewrite of objtool. Instead of only tracking frame > pointer changes, it now tracks all stack-related operations, including > all register saves/restores. > > In addition to making stack validation more robust, this also paves the > way for undwarf generation. > > Signed-off-by: Josh Poimboeuf Note, I have applied the first 3 patches, and got a bunch of new warnings on x86 64-bit allmodconfig: arch/x86/kernel/alternative.o: warning: objtool: do_sync_core()+0x1b: unsupported instruction in callable function arch/x86/kernel/alternative.o: warning: objtool: text_poke()+0x1a8: unsupported instruction in callable function arch/x86/kernel/ftrace.o: warning: objtool: do_sync_core()+0x16: unsupported instruction in callable function arch/x86/kernel/cpu/mcheck/mce.o: warning: objtool: machine_check_poll()+0x166: unsupported instruction in callable function arch/x86/kernel/cpu/mcheck/mce.o: warning: objtool: do_machine_check()+0x147: unsupported instruction in callable function (That's the vmlinux build - plus 4 more warnings in the modules build.) That's with GCC 5.3.1. Let me know if you need any more info. Thanks, Ingo