Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751917AbdF3JEF (ORCPT ); Fri, 30 Jun 2017 05:04:05 -0400 Received: from fllnx209.ext.ti.com ([198.47.19.16]:25636 "EHLO fllnx209.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751599AbdF3JED (ORCPT ); Fri, 30 Jun 2017 05:04:03 -0400 Subject: Re: [BISECTED, REGRESSION] v4.12-rc: omapdrm fails to probe on Nokia N900 To: Aaro Koskinen CC: Peter Ujfalusi , Tony Lindgren , , , , Laurent Pinchart References: <20170614221133.k7gmbzzjsbmbjgbc@darkstar.musicnaut.iki.fi> <20170629185013.aec7qhvrl3waifww@darkstar.musicnaut.iki.fi> <20170630085851.j5apctivufhmhp64@darkstar.musicnaut.iki.fi> From: Tomi Valkeinen Message-ID: <5bc9976e-228c-5cba-c2ae-bfc5135f17a0@ti.com> Date: Fri, 30 Jun 2017 12:02:48 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <20170630085851.j5apctivufhmhp64@darkstar.musicnaut.iki.fi> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="SP3tQL17KfaAoru5RkgA9tlUnEBc9q09U" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3737 Lines: 96 --SP3tQL17KfaAoru5RkgA9tlUnEBc9q09U Content-Type: multipart/mixed; boundary="r1DQ2L6cLDM9jwXxTswNAbg0oHv2OMa8P"; protected-headers="v1" From: Tomi Valkeinen To: Aaro Koskinen Cc: Peter Ujfalusi , Tony Lindgren , linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, dri-devel@lists.freedesktop.org, Laurent Pinchart Message-ID: <5bc9976e-228c-5cba-c2ae-bfc5135f17a0@ti.com> Subject: Re: [BISECTED, REGRESSION] v4.12-rc: omapdrm fails to probe on Nokia N900 References: <20170614221133.k7gmbzzjsbmbjgbc@darkstar.musicnaut.iki.fi> <20170629185013.aec7qhvrl3waifww@darkstar.musicnaut.iki.fi> <20170630085851.j5apctivufhmhp64@darkstar.musicnaut.iki.fi> In-Reply-To: <20170630085851.j5apctivufhmhp64@darkstar.musicnaut.iki.fi> --r1DQ2L6cLDM9jwXxTswNAbg0oHv2OMa8P Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 30/06/17 11:58, Aaro Koskinen wrote: > Hi, >=20 > On Fri, Jun 30, 2017 at 09:41:35AM +0300, Tomi Valkeinen wrote: >> On 29/06/17 21:50, Aaro Koskinen wrote: >>> On Thu, Jun 15, 2017 at 09:51:06AM +0300, Tomi Valkeinen wrote: >>>> On 15/06/17 01:11, Aaro Koskinen wrote: >>>>> When booting v4.12-rc5 on Nokia N900, omapdrm fails to probe and th= ere >>>>> is no display. >>>> >>>> Are you sure it doesn't probe? It fails the omapdss_stack_is_ready()= >>>> check? >>> >>> It appears the reason was that I didn't have >>> CONFIG_DRM_OMAP_CONNECTOR_ANALOG_TV enabled. >>> >>> I think that's wrong. I don't own an analog TV, so why should I enabl= e >>> such option to get device's built-in display working? >> >> Indeed. Unfortunately I don't have a solution for that. >> >> DRM doesn't support adding devices after probe. So at omapdrm probe ti= me >> we have to decide which displays to use. In the dts file, n900 defines= >> the lcd and analog tv. omapdrm sees those, and, of course, must wait >> until their respective drivers have probed. If you don't have the >> display driver enabled, it's never loaded and omapdrm never probes as = it >> keeps waiting for those. >=20 > Could you at least print some kind of message early in the boot ("omapd= rm > is waiting for drivers for display x and y")? That could be quite spammy. omapdrm will defer probe if the displays are not present, and the deferred probing machinery will then cause a new omapdrm probe later. That can happen a lot of times before the drivers are there. Tomi --r1DQ2L6cLDM9jwXxTswNAbg0oHv2OMa8P-- --SP3tQL17KfaAoru5RkgA9tlUnEBc9q09U Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJZVhO4AAoJEPo9qoy8lh71SwAP/AzenYHX4vY19wJUq+O0EH1c 34uMQZmLGmfbzp5pSOkccx2zjeWCcfIMsHwtWaVZEd9iBJj4XcNezovo5d/uXudG Q9iLDLi2m451aPfS3CfC9yeVVIoUgofogMB5S06c4SsyAYCHbfWcxeXSB4T/A8Lg N+YoJnPf7GC4YUqTItosDKW5jwvHz2UqsxbXEidayZJwMkqBfnXAgnpQ6EjUFLzV gp7ljLnp8aR4o1/Nm7+etdfaYhizO6YWW2G4MDWibv1uzpSu7ROQPCNRUuISPJMK 7lg+P9WI0v2ItG2Epj7JeKKKzopjxaY6rkfXPcAkTfPWtkHP3Pl6KPxnnD+5YkMI NwP73ztkCAQ0NvI2MU1N0sdK9XeBTpDGKfitMWQ1TcIxfosOf66lSJlWSXf4PyfT oboik0J341GcxfFSSesdEcglYSKb9T/wH6ECWDBfa1qRVmgt+apoSDbM/+Je7owQ OxklfY02//WJ6ePYyJJk4bSAFr5HBrqJGloAMpuIe+UCB5Xg+xS4VxybdhXOqSEz 4imQJf4Y1IwkX0fRNbhEo/CYFwwdHy6BUxhwjswNbXSJzEF2ezQTyzxW8wHVU5eh N1t+37WCJi3tT6T+jwLWyxjMdL7Uw3UESO9GDBeQe3krIfgcwGZoVKRvEWJu6daH fvqci6ZTOKOsDonfoDfZ =Mnka -----END PGP SIGNATURE----- --SP3tQL17KfaAoru5RkgA9tlUnEBc9q09U--