Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751886AbdF3Jdj (ORCPT ); Fri, 30 Jun 2017 05:33:39 -0400 Received: from mail-pf0-f196.google.com ([209.85.192.196]:35775 "EHLO mail-pf0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751638AbdF3Jdg (ORCPT ); Fri, 30 Jun 2017 05:33:36 -0400 From: Arvind Yadav To: tyhicks@canonical.com, viro@zeniv.linux.org.uk Cc: ecryptfs@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] eCryptfs: constify attribute_group structures. Date: Fri, 30 Jun 2017 15:03:23 +0530 Message-Id: X-Mailer: git-send-email 1.9.1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 959 Lines: 32 attribute_groups are not supposed to change at runtime. All functions working with attribute_groups provided by work with const attribute_group. So mark the non-const structs as const. File size before: text data bss dec hex filename 6122 636 24 6782 1a7e fs/ecryptfs/main.o File size After adding 'const': text data bss dec hex filename 6186 604 24 6814 1a9e fs/ecryptfs/main.o Signed-off-by: Arvind Yadav --- fs/ecryptfs/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/ecryptfs/main.c b/fs/ecryptfs/main.c index 9014479..eea4c0f 100644 --- a/fs/ecryptfs/main.c +++ b/fs/ecryptfs/main.c @@ -782,7 +782,7 @@ static ssize_t version_show(struct kobject *kobj, NULL, }; -static struct attribute_group attr_group = { +static const struct attribute_group attr_group = { .attrs = attributes, }; -- 1.9.1