Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751887AbdF3Jmp (ORCPT ); Fri, 30 Jun 2017 05:42:45 -0400 Received: from mail-lf0-f45.google.com ([209.85.215.45]:33745 "EHLO mail-lf0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751695AbdF3Jml (ORCPT ); Fri, 30 Jun 2017 05:42:41 -0400 Subject: Re: [PATCH] sata_rcar: fix error return code in sata_rcar_probe() To: "Gustavo A. R. Silva" , Tejun Heo Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org References: <20170630052210.GA19186@embeddedgus> From: Sergei Shtylyov Message-ID: Date: Fri, 30 Jun 2017 12:42:38 +0300 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170630052210.GA19186@embeddedgus> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 376 Lines: 15 Hello! On 6/30/2017 8:22 AM, Gustavo A. R. Silva wrote: > Print error message and propagate the return value of > platform_get_irq on failure. You should have probably mentioned that this function no longer returns 0 on error. > Signed-off-by: Gustavo A. R. Silva Acked-by: Sergei Shtylyov MBR, Sergei