Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751935AbdF3JvW (ORCPT ); Fri, 30 Jun 2017 05:51:22 -0400 Received: from mail-vk0-f66.google.com ([209.85.213.66]:35564 "EHLO mail-vk0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751886AbdF3JvU (ORCPT ); Fri, 30 Jun 2017 05:51:20 -0400 MIME-Version: 1.0 In-Reply-To: <1498726284-10182-1-git-send-email-bhumirks@gmail.com> References: <1498726284-10182-1-git-send-email-bhumirks@gmail.com> From: "Lad, Prabhakar" Date: Fri, 30 Jun 2017 10:50:48 +0100 Message-ID: Subject: Re: [PATCH] [media] media/platform: add const to v4l2_file_operations structures To: Bhumika Goyal Cc: Julia Lawall , Scott Jiang , Mauro Carvalho Chehab , Guennadi Liakhovetski , adi-buildroot-devel@lists.sourceforge.net, linux-media , LKML Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 938 Lines: 29 Hi, Thanks for the patch. On Thu, Jun 29, 2017 at 9:51 AM, Bhumika Goyal wrote: > Declare v4l2_file_operations structures as const as they are only stored > in the fops field of video_device structures. This field is of type > const, so declare v4l2_file_operations structures with similar properties > as const. > > Cross compiled bfin_capture.o for blackfin arch. vpbe_display.o file did > not cross compile for arm. Could not find any architecture matching the > configuraion symbol for fsl-viu.c file. > s/configuraion/configuration Ideally the above statement should go below --- (after the signoff) so that its not the part of commit message. > Signed-off-by: Bhumika Goyal > --- > drivers/media/platform/davinci/vpbe_display.c | 2 +- > drivers/media/platform/davinci/vpif_capture.c | 2 +- For above: Acked-by: Lad, Prabhakar Cheers, --Prabhakar Lad