DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com E2C1D85547
Subject: Re: [PATCH v2] KVM: x86: remove ignored type attribute
To: Nick Desaulniers <nick.desaulniers@gmail.com>
Cc: =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= <rkrcmar@redhat.com>,
        Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
        "H. Peter Anvin" <hpa@zytor.com>, x86@kernel.org, kvm@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20170623044120.6296-1-nick.desaulniers@gmail.com>
 <20170628023714.32158-1-nick.desaulniers@gmail.com>
From: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <cace40f9-2d90-c27b-675d-4d12a4e2ddc6@redhat.com>
Date: Fri, 30 Jun 2017 12:46:07 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.2.0
MIME-Version: 1.0
In-Reply-To: <20170628023714.32158-1-nick.desaulniers@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1139
Lines: 35


On 28/06/2017 04:37, Nick Desaulniers wrote:
> The macro insn_fetch marks the 'type' argument as having a specified
> alignment.  Type attributes can only be applied to structs, unions, or
> enums, but insn_fetch is only ever invoked with integral types, so Clang
> produces 19 -Wignored-attributes warnings for this source file.
> 
> Signed-off-by: Nick Desaulniers <nick.desaulniers@gmail.com>
> ---
> Changes in v2:
> * prefer memcpy
> * fix up trailing tabs
> 
>  arch/x86/kvm/emulate.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/x86/kvm/emulate.c b/arch/x86/kvm/emulate.c
> index 7611c034bf95..f9c0359f3fdd 100644
> --- a/arch/x86/kvm/emulate.c
> +++ b/arch/x86/kvm/emulate.c
> @@ -900,7 +900,7 @@ static __always_inline int do_insn_fetch_bytes(struct x86_emulate_ctxt *ctxt,
>  	if (rc != X86EMUL_CONTINUE)					\
>  		goto done;						\
>  	ctxt->_eip += sizeof(_type);					\
> -	_x = *(_type __aligned(1) *) ctxt->fetch.ptr;			\
> +	memcpy(&_x, ctxt->fetch.ptr, sizeof(_type));		\
>  	ctxt->fetch.ptr += sizeof(_type);				\
>  	_x;								\
>  })
> 

Fixed up the tab and pushed, thanks.

Paolo