Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752026AbdF3Lnp (ORCPT ); Fri, 30 Jun 2017 07:43:45 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59204 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751563AbdF3LnK (ORCPT ); Fri, 30 Jun 2017 07:43:10 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 877EC61B83 Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=jmarchan@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 877EC61B83 Subject: Re: [PATCH] mm/zsmalloc: simplify zs_max_alloc_size handling To: Minchan Kim Cc: Nitin Gupta , Sergey Senozhatsky , Mahendran Ganesh , linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20170628081420.26898-1-jmarchan@redhat.com> <20170630012436.GA24520@bbox> From: Jerome Marchand Message-ID: Date: Fri, 30 Jun 2017 13:43:02 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0 MIME-Version: 1.0 In-Reply-To: <20170630012436.GA24520@bbox> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="6AmdaNKWH3dSHuaCANCd9pS7ER1IsnF6B" X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Fri, 30 Jun 2017 11:43:09 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2187 Lines: 66 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --6AmdaNKWH3dSHuaCANCd9pS7ER1IsnF6B Content-Type: multipart/mixed; boundary="8SJO4hWcIW9AbbMLqdxjMcHGjFkkkBrNn"; protected-headers="v1" From: Jerome Marchand To: Minchan Kim Cc: Nitin Gupta , Sergey Senozhatsky , Mahendran Ganesh , linux-mm@kvack.org, linux-kernel@vger.kernel.org Message-ID: Subject: Re: [PATCH] mm/zsmalloc: simplify zs_max_alloc_size handling References: <20170628081420.26898-1-jmarchan@redhat.com> <20170630012436.GA24520@bbox> In-Reply-To: <20170630012436.GA24520@bbox> --8SJO4hWcIW9AbbMLqdxjMcHGjFkkkBrNn Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 06/30/2017 03:24 AM, Minchan Kim wrote: >> @@ -137,6 +142,8 @@ >> * (reason above) >> */ >> #define ZS_SIZE_CLASS_DELTA (PAGE_SIZE >> CLASS_BITS) >> +#define ZS_SIZE_CLASSES DIV_ROUND_UP(ZS_MAX_ALLOC_SIZE - ZS_MIN_ALLOC= _SIZE, \ >> + ZS_SIZE_CLASS_DELTA) >=20 > #define ZS_SIZE_CLASSES (DIV_ROUND_UP(ZS_MAX_ALLOC_SIZE - ZS_MIN_ALLOC_= SIZE, \ > ZS_SIZE_CLASS_DELTA) + 1) >=20 >=20 > I think it should add +1 to cover ZS_MIN_ALLOC_SIZE. Yes, obviously. Sorry about that. > Otherwise, looks good to me. >=20 > Thanks. >=20 --8SJO4hWcIW9AbbMLqdxjMcHGjFkkkBrNn-- --6AmdaNKWH3dSHuaCANCd9pS7ER1IsnF6B Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJZVjlGAAoJEHTzHJCtsuoCkXIH/0ZHgdvBG5DIx/+re7i5hl3w +Z3H9tfLpmKgoQB1RuVHd1PTEF36B6viXqNV0fQdIYVpciV4WJWW53lO7mQy10DO 3XqJHGjbjSp37lnfcUv3XbanT2TqKi4QZjSW1QIYIHl7sVzsG/hSjgI5cRTKNHcx W17iRqv3dUIjIwBMtubLIZeSOw14P4U6EHXVZLEt4HGhuxgKW++6HfWRBbS1eOPP lQRwppD48MoD/SPD2jQBQXqiqkUCJbj40NwOflbkRCnJq3RItuxjew85dWO3KkgT 8fjS3JDC8iCF2B3j4/NFIiVAR1ssVs/P6KUltqqjPcVz3qlSI2I4MeakCXsQu/g= =sQOR -----END PGP SIGNATURE----- --6AmdaNKWH3dSHuaCANCd9pS7ER1IsnF6B--