Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752121AbdF3MB0 (ORCPT ); Fri, 30 Jun 2017 08:01:26 -0400 Received: from mail-qk0-f178.google.com ([209.85.220.178]:34683 "EHLO mail-qk0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751581AbdF3MBJ (ORCPT ); Fri, 30 Jun 2017 08:01:09 -0400 Date: Fri, 30 Jun 2017 08:01:06 -0400 From: Tejun Heo To: Sergei Shtylyov Cc: "Gustavo A. R. Silva" , linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] sata_rcar: fix error return code in sata_rcar_probe() Message-ID: <20170630120106.GB16820@htj.duckdns.org> References: <20170630052210.GA19186@embeddedgus> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.8.3 (2017-05-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 475 Lines: 19 On Fri, Jun 30, 2017 at 12:42:38PM +0300, Sergei Shtylyov wrote: > Hello! > > On 6/30/2017 8:22 AM, Gustavo A. R. Silva wrote: > > > Print error message and propagate the return value of > > platform_get_irq on failure. > > You should have probably mentioned that this function no longer returns 0 > on error. Yeah, the patches looks good to me but I'd really appreciate more context in the changelogs. Gustavo, can you please respin the patches? Thanks. -- tejun