Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S262373AbTFOQjM (ORCPT ); Sun, 15 Jun 2003 12:39:12 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262382AbTFOQjM (ORCPT ); Sun, 15 Jun 2003 12:39:12 -0400 Received: from neon-gw-l3.transmeta.com ([63.209.4.196]:10513 "EHLO neon-gw.transmeta.com") by vger.kernel.org with ESMTP id S262373AbTFOQjL (ORCPT ); Sun, 15 Jun 2003 12:39:11 -0400 Date: Sun, 15 Jun 2003 09:52:47 -0700 (PDT) From: Linus Torvalds To: Andi Kleen cc: linux-kernel@vger.kernel.org, Subject: Re: [PATCH] Fix undefined/miscompiled construct in kernel parameters In-Reply-To: <20030615125854.GA29458@averell> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 675 Lines: 18 On Sun, 15 Jun 2003, Andi Kleen wrote: > > The parse_args call in init/main.c does pointer arithmetic between two > different external symbols. This is undefined in C (only pointer arthmetic > in the same symbol is defined) and gets miscompiled on AMD64 with gcc 3.2, That's silly. You're making the code less readable, with some silly parameters. Why does it get miscompiled on amd64, and let's just fix that one. Linus - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/