Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751967AbdF3M27 (ORCPT ); Fri, 30 Jun 2017 08:28:59 -0400 Received: from esa6.microchip.iphmx.com ([216.71.154.253]:5353 "EHLO esa6.microchip.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751560AbdF3M2z (ORCPT ); Fri, 30 Jun 2017 08:28:55 -0400 X-IronPort-AV: E=Sophos;i="5.40,286,1496127600"; d="scan'208";a="1858821" Subject: Re: [PATCH 5/5] ARM: dts: sama5d27_som1_ek: Add sama5d27 SoM1 EK support To: Alexandre Belloni , Baruch Siach CC: , , , , , , , , References: <1498736674-9233-1-git-send-email-claudiu.beznea@microchip.com> <1498736674-9233-6-git-send-email-claudiu.beznea@microchip.com> <20170629115931.yki2xbehyicbtx3w@tarshish> <20170629121655.37pq7cnabvv4wh7z@piout.net> From: m18063 Message-ID: Date: Fri, 30 Jun 2017 15:28:51 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <20170629121655.37pq7cnabvv4wh7z@piout.net> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 945 Lines: 36 Hi Baruch, Alexandre On 29.06.2017 15:16, Alexandre Belloni wrote: > On 29/06/2017 at 14:59:31 +0300, Baruch Siach wrote: >> Hi Claudiu, >> >> On Thu, Jun 29, 2017 at 02:44:34PM +0300, Claudiu Beznea wrote: >>> Add specifig DTS files and bindings for sama5d27 SoM1 EK board. >> >> Is there any publicly available information on this SoM? >> >> One more comment below. >> >>> Signed-off-by: Claudiu Beznea >>> Signed-off-by: Cristian Birsan >>> --- >> >> [snip] >> >>> + memory { >>> + reg = <0x20000000 0x20000>; >> >> Are you sure this SoM has 132KB RAM? Yes, here is a mistake, the size is 128MB. Sorry for the noise. >> >> Since you seem to rely on the bootloader to fill in the right size value, you >> can just drop this node and rely on sama5d2.dtsi that provides a stub node. >> > > Yeah, that is what I would do too. Ok, I will do it so in v2. Thank you, Claudiu > >