Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752047AbdF3MhE (ORCPT ); Fri, 30 Jun 2017 08:37:04 -0400 Received: from mail-lf0-f43.google.com ([209.85.215.43]:36824 "EHLO mail-lf0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751784AbdF3MgB (ORCPT ); Fri, 30 Jun 2017 08:36:01 -0400 Subject: Re: [PATCH] sata_rcar: fix error return code in sata_rcar_probe() To: "Gustavo A. R. Silva" , Tejun Heo References: <20170630052210.GA19186@embeddedgus> Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org From: Sergei Shtylyov Organization: Cogent Embedded Message-ID: <3273ba2f-ea32-0ed6-5d84-39a80e627be6@cogentembedded.com> Date: Fri, 30 Jun 2017 15:35:57 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 361 Lines: 12 On 06/30/2017 12:42 PM, Sergei Shtylyov wrote: >> Print error message and propagate the return value of >> platform_get_irq on failure. > > You should have probably mentioned that this function no longer returns 0 > on error. It's prolly also worth mentioning that enforcing the error # on return from probe defeats the deferred probing. MBR, Sergei