Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752207AbdF3Nm1 (ORCPT ); Fri, 30 Jun 2017 09:42:27 -0400 Received: from mx1.redhat.com ([209.132.183.28]:50738 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751563AbdF3Nm0 (ORCPT ); Fri, 30 Jun 2017 09:42:26 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 32214C0467D8 Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=rpeterso@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 32214C0467D8 Date: Fri, 30 Jun 2017 09:42:23 -0400 (EDT) From: Bob Peterson To: Arvind Yadav Cc: swhiteho@redhat.com, torvalds@linux-foundation.org, cluster-devel@redhat.com, linux-kernel@vger.kernel.org Message-ID: <1521062963.27753093.1498830143169.JavaMail.zimbra@redhat.com> In-Reply-To: References: Subject: Re: [PATCH] fs: GFS2: constify attribute_group structures. MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [10.10.64.2, 10.4.195.27] Thread-Topic: GFS2: constify attribute_group structures. Thread-Index: nXr+oPX0BsasRv4igC6dwR7SHCiNjw== X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Fri, 30 Jun 2017 13:42:26 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 749 Lines: 25 ----- Original Message ----- | attribute_groups are not supposed to change at runtime. All functions | working with attribute_groups provided by work with const | attribute_group. So mark the non-const structs as const. | | File size before: | text data bss dec hex filename | 5259 1344 8 6611 19d3 fs/gfs2/sys.o | | File size After adding 'const': | text data bss dec hex filename | 5371 1216 8 6595 19c3 fs/gfs2/sys.o | | Signed-off-by: Arvind Yadav Hi, Thanks. This is now applied to the for-next branch of the linux-gfs2 tree: 1fc2e87 GFS2: constify attribute_group structures. Regards, Bob Peterson Red Hat File Systems