Date: Sun, 15 Jun 2003 19:39:26 +0200
From: =?iso-8859-1?Q?J=F6rn?= Engel <joern@wohnheim.fh-wedel.de>
To: Christoph Hellwig <hch@infradead.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] make cramfs look less hostile
Message-ID: <20030615173926.GH1063@wohnheim.fh-wedel.de>
References: <20030615160524.GD1063@wohnheim.fh-wedel.de> <20030615182642.A19479@infradead.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20030615182642.A19479@infradead.org>
User-Agent: Mutt/1.3.28i
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1285
Lines: 29

On Sun, 15 June 2003 18:26:42 +0100, Christoph Hellwig wrote:
> On Sun, Jun 15, 2003 at 06:05:24PM +0200, J?rn Engel wrote:
> > 
> > This thing has been biting me now and again.  "cramfs: wrong magic\n"
> > looks like an error condition to most people and thus creates bug
> > reports.  But there is no bug per se in having cramfs support in the
> > kernel and booting from a jffs2 rootfs.  So instead of teaching the
> > users over and over, how about this little one-liner?
> 
> Umm, cramfs_fill_super has a silent parameter that's true for
> probing the root filesystem.  I'd suggest disabling the printk
> completly if it's set.

Good idea, but only at first glance.  cramfs_fill_super() always gets
called with silent=1.  So if "(!silent) printk(...);" is functionally
equivalent to ";".

J?rn

-- 
The competent programmer is fully aware of the strictly limited size of
his own skull; therefore he approaches the programming task in full
humility, and among other things he avoids clever tricks like the plague. 
-- Edsger W. Dijkstra
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/