Subject: Re: [PATCH 0/4] Convert to TAP13 using ksft_ var arg msg api
To: Shuah Khan <shuahkh@osg.samsung.com>, shuah@kernel.org,
        alice.ferrazzi@gmail.com, gregkh@linuxfoundation.org,
        labath@google.com, panand@redhat.com, will.deacon@arm.com
Cc: linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org
References: <cover.1498777889.git.shuahkh@osg.samsung.com>
From: Paul Elder <paul.elder@pitt.edu>
Message-ID: <6fb6618f-7f39-dd6b-07bb-0e7e9929e6e1@pitt.edu>
Date: Sat, 1 Jul 2017 01:13:35 +0900
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.2.1
MIME-Version: 1.0
In-Reply-To: <cover.1498777889.git.shuahkh@osg.samsung.com>
Content-Type: text/plain; charset=windows-1252
Content-Language: en-US
Content-Transfer-Encoding: 7bit
SpamDiagnosticOutput: 1:99
SpamDiagnosticMetadata: NSPM
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Jun 2017 16:13:53.5955 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR04MB2170
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1346
Lines: 35

On 06/30/2017 08:18 AM, Shuah Khan wrote:
> This patch series converts breakpoint_test_arm64 to TAP13 output. Uses
> ksft_ var arg msg functions as needed. Changed to ensure parent is the
> one that increments test counters.
> 
> breakpoint_test, step_after_suspend_test, membarrier tests are changed
> to use ksft_ var arg msg functions as needed.
> 
> This patch series depends on Paul Elder's
> 
> [PATCH v2 0/2] kselftest: make ksft_* output functions variadic
> The v2 series doesn't append newline and makes it easier to use.
> 
> Shuah Khan (4):
>   selftests: breakpoint_test: use ksft_* var arg msg api
>   selftests: breakpoints: step_after_suspend_test use ksft_* var arg msg
>     api
>   selftests: breakpoints: breakpoint_test_arm64: convert test to use
>     TAP13
>   selftests: membarrier: use ksft_* var arg msg api
> 
>  .../selftests/breakpoints/breakpoint_test.c        | 28 ++++---
>  .../selftests/breakpoints/breakpoint_test_arm64.c  | 94 +++++++++++++---------
>  .../breakpoints/step_after_suspend_test.c          | 59 ++++++++------
>  .../testing/selftests/membarrier/membarrier_test.c | 91 ++++++++++-----------
>  4 files changed, 148 insertions(+), 124 deletions(-)
> 
Looks good to me.

Although I am wondering why you said earlier that you were going to go with
my v1, while this depends on v2.

Thank you,

Paul