Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S262426AbTFORfb (ORCPT ); Sun, 15 Jun 2003 13:35:31 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262444AbTFORfb (ORCPT ); Sun, 15 Jun 2003 13:35:31 -0400 Received: from smtpzilla1.xs4all.nl ([194.109.127.137]:23825 "EHLO smtpzilla1.xs4all.nl") by vger.kernel.org with ESMTP id S262426AbTFORf0 (ORCPT ); Sun, 15 Jun 2003 13:35:26 -0400 Date: Sun, 15 Jun 2003 19:48:56 +0200 (CEST) From: Roman Zippel X-X-Sender: roman@serv To: Andi Kleen cc: Linus Torvalds , Andi Kleen , Subject: Re: [PATCH] Fix undefined/miscompiled construct in kernel parameters In-Reply-To: <20030615193256.29257@colin.muc.de> Message-ID: References: <20030615193256.29257@colin.muc.de> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1471 Lines: 42 Hi, On 15 Jun 2003, Andi Kleen wrote: > I tend to agree, feel free to flame them. But it doesn't help me right now > when I want to get a booting kernel. Could you merge that change or if you > prefer I can rewrite it to anonymous asm (but it will be probably more ugly). > I just need some workaround. Does the patch below work better? bye, Roman --- linux/init/main.c 14 Jun 2003 23:01:48 -0000 1.1.1.41 +++ linux/init/main.c 15 Jun 2003 17:46:16 -0000 @@ -383,7 +383,7 @@ asmlinkage void __init start_kernel(void { char * command_line; extern char saved_command_line[]; - extern struct kernel_param __start___param, __stop___param; + extern struct kernel_param __start___param[], __stop___param[]; /* * Interrupts are still disabled. Do necessary setups, then * enable them @@ -403,8 +403,8 @@ asmlinkage void __init start_kernel(void build_all_zonelists(); page_alloc_init(); printk("Kernel command line: %s\n", saved_command_line); - parse_args("Booting kernel", command_line, &__start___param, - &__stop___param - &__start___param, + parse_args("Booting kernel", command_line, __start___param, + __stop___param - __start___param, &unknown_bootoption); trap_init(); rcu_init(); - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/