Subject: Re: [PATCH 0/4] Convert to TAP13 using ksft_ var arg msg api
To: shuah@kernel.org, alice.ferrazzi@gmail.com, gregkh@linuxfoundation.org,
        labath@google.com, panand@redhat.com, will.deacon@arm.com
Cc: Shuah Khan <shuahkh@osg.samsung.com>, linux-kselftest@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <cover.1498777889.git.shuahkh@osg.samsung.com>
 <6fb6618f-7f39-dd6b-07bb-0e7e9929e6e1@pitt.edu>
 <3d5e18c0-781d-b9d3-c9df-c02e62ded88d@kernel.org>
From: Paul Elder <paul.elder@pitt.edu>
Message-ID: <96a11585-e45f-23c0-fefe-100938ad321d@pitt.edu>
Date: Sat, 1 Jul 2017 01:52:40 +0900
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.2.1
MIME-Version: 1.0
In-Reply-To: <3d5e18c0-781d-b9d3-c9df-c02e62ded88d@kernel.org>
Content-Type: text/plain; charset=windows-1252
Content-Language: en-US
Content-Transfer-Encoding: 8bit
SpamDiagnosticOutput: 1:99
SpamDiagnosticMetadata: NSPM
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Jun 2017 16:52:53.7864 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN2PR04MB2173
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 2580
Lines: 75

On 07/01/2017 01:33 AM, Shuah Khan wrote:
> On 06/30/2017 10:13 AM, Paul Elder wrote:
>> On 06/30/2017 08:18 AM, Shuah Khan wrote:
>>> This patch series converts breakpoint_test_arm64 to TAP13 output. Uses
>>> ksft_ var arg msg functions as needed. Changed to ensure parent is the
>>> one that increments test counters.
>>>
>>> breakpoint_test, step_after_suspend_test, membarrier tests are changed
>>> to use ksft_ var arg msg functions as needed.
>>>
>>> This patch series depends on Paul Elder's
>>>
>>> [PATCH v2 0/2] kselftest: make ksft_* output functions variadic
>>> The v2 series doesn't append newline and makes it easier to use.
>>>
>>> Shuah Khan (4):
>>>   selftests: breakpoint_test: use ksft_* var arg msg api
>>>   selftests: breakpoints: step_after_suspend_test use ksft_* var arg msg
>>>     api
>>>   selftests: breakpoints: breakpoint_test_arm64: convert test to use
>>>     TAP13
>>>   selftests: membarrier: use ksft_* var arg msg api
>>>
>>>  .../selftests/breakpoints/breakpoint_test.c        | 28 ++++---
>>>  .../selftests/breakpoints/breakpoint_test_arm64.c  | 94 +++++++++++++---------
>>>  .../breakpoints/step_after_suspend_test.c          | 59 ++++++++------
>>>  .../testing/selftests/membarrier/membarrier_test.c | 91 ++++++++++-----------
>>>  4 files changed, 148 insertions(+), 124 deletions(-)
>>>
>> Looks good to me.
>>
>> Although I am wondering why you said earlier that you were going to go with
>> my v1, while this depends on v2.
>>
>> Thank you,
>>
>> Paul
>>
>>
> 
> Yeah my bad!
> 
> I was playing with both v1 and v2 for my testing. I lost track of which one worked
> well. I had to start from square one and re-test.
Oh okay. Understood.

> 
> v2 by not appending newline, allows custom formats in individual test messages.
> For example, a test wants to use tabs between two ksft_print_msg() calls or _report_
> messages. v2 is flexible and works better and leds itself well. Users can just pass
> the format and expect it to stick.
I see. I didn't notice this advantage. Though if a test wants to separate two
ksft_print_msg()s with tabs, wouldn't there still be a # between them?

> 
> If there are no issues with this series, I plan to apply your v2 series and this
> series later on today or early tomorrow to linux-kselftest next.
I have no objections.

> 
> If we have this infrastructure in place, we will be able to make progress in the
> next release with the TAP13 conversion of other tests.
Indeed. Although I'm having trouble with tests that fork.

Thank you!

Paul

> 
> thanks,
> -- Shuah
> 
> thanks,
> -- Shuah
>