MIME-Version: 1.0
In-Reply-To: <alpine.DEB.2.20.1706301623040.1748@nanos>
References: <20170316215057.452220163@linutronix.de> <tip-b5b0f00c760b6e9673ab79b88ede2f3c7a039f74@git.kernel.org>
 <CAE9FiQVAqZRtMLKTtySaCiCbDicN0h=6dPXEGP1M2eAq9AiYXQ@mail.gmail.com>
 <20170630031849.GP23705@tassilo.jf.intel.com> <alpine.DEB.2.20.1706301623040.1748@nanos>
From: Linus Torvalds <torvalds@linux-foundation.org>
Date: Fri, 30 Jun 2017 10:16:15 -0700
Message-ID: <CA+55aFwi0tkdugfqNEz6M28RXM2jx6WpaDF4nfA=doUVdZgUNQ@mail.gmail.com>
Subject: Re: [tip:x86/platform] x86/PCI/mmcfg: Switch to ECAM config mode if possible
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Andi Kleen <ak@linux.intel.com>, Yinghai Lu <yinghai@kernel.org>,
        Stephane Eranian <eranian@google.com>,
        "H. Peter Anvin" <hpa@zytor.com>, Ingo Molnar <mingo@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>, Borislav Petkov <bp@alien8.de>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Bjorn Helgaas <helgaas@kernel.org>,
        Matthew Wilcox <willy@linux.intel.com>,
        Ivan Kokshaysky <ink@jurassic.park.msu.ru>,
        "linux-tip-commits@vger.kernel.org" 
        <linux-tip-commits@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1304
Lines: 38

On Fri, Jun 30, 2017 at 7:30 AM, Thomas Gleixner <tglx@linutronix.de> wrote:
>> But MCFG problems were a long time ago and noone uses these systems anymore,
>> so perhaps he is right.
>
> The obvious solution to this is to force type 1 for older machines, i.e. <=
> K8. Some day we should stop supporting 15+ years old crap just because we
> can.

No.

The fact is, type 1 is the *good* thing.  It's the standard thing that
has worked pretty much forever, and that is not just tested, but has
good semantics.

The new stuff is the crazy crap. It's crazy crap in so many ways:

 - non-deterministic memory addresses found in firmware tables that
have had bugs

 - using MMIO means that there are lots of basic issues with
fundamental things like write gathering and ordering

The right thing to do is to just admit that the extended mmcfg isn't
actually the rigth thjing to do by default, and only use it when you
have to.

"Newer" does not always mean "better", and there's been lots of bad
hardware (and bad firmware).

So use the "enhanced" one for stuff above the 256-byte limit. Not for
basic probing.

Anmd don't think that it should be phased out just because it's old.

Old is often *good*. Old means stable. Old means tested. Old means
simple. Those are all *good* thing.

                 Linus