DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 2CC865D688
Subject: Re: [PATCH v2] ACPI: surface3_power: MSHW0011 rev-eng implementation
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com>,
        Bastien Nocera <hadess@hadess.net>,
        Stephen Just <stephenjust@gmail.com>,
        Sebastian Reichel <sre@kernel.org>,
        "Rafael J . Wysocki" <rafael.j.wysocki@intel.com>,
        Len Brown <lenb@kernel.org>, Robert Moore <robert.moore@intel.com>,
        Lv Zheng <lv.zheng@intel.com>,
        Mika Westerberg <mika.westerberg@linux.intel.com>,
        "linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
        devel@acpica.org,
        "linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
References: <20170629121009.30234-1-benjamin.tissoires@redhat.com>
 <CAHp75Vdn1-m0gDSHtZXX2A=Q07xG9j1eBiV8iM4e11Qk=oJfZg@mail.gmail.com>
 <20170630155706.GL26073@mail.corp.redhat.com>
 <CAHp75VdLU57x2YuDH+SkB1jR3rSpqcVNszhq5fDUVZZt+sqxyQ@mail.gmail.com>
 <7d8201bf-b05e-6235-7eb0-54b1a393f99f@redhat.com>
 <CAHp75VfWmAvaASLZOhmMBW7v+E10_7xvD11OSMKdQ0HbY_yHVg@mail.gmail.com>
From: Hans de Goede <hdegoede@redhat.com>
Message-ID: <eb6ad1a4-3538-a8f8-e8c2-c3781a90c37f@redhat.com>
Date: Fri, 30 Jun 2017 19:42:06 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.2.1
MIME-Version: 1.0
In-Reply-To: <CAHp75VfWmAvaASLZOhmMBW7v+E10_7xvD11OSMKdQ0HbY_yHVg@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1351
Lines: 36

Hi,

On 30-06-17 19:40, Andy Shevchenko wrote:
> On Fri, Jun 30, 2017 at 8:37 PM, Hans de Goede <hdegoede@redhat.com> wrote:
>> On 30-06-17 18:37, Andy Shevchenko wrote:
>>> On Fri, Jun 30, 2017 at 6:57 PM, Benjamin Tissoires
> 
>> ACPI i2c drivers still need an empty i2c_device_id table I've
>> fixing this on my TODO but it has been buried in other stuff.
>>
>> Benjamin if (not saying you should, but if) you want to take a look at
>> this, fixing the need for the empty table for ACPI devices should be
>> easy. The problem is these lines in drivers/i2c/i2c-core.c:
>> i2c_device_probe():
>>
>>          /*
>>           * An I2C ID table is not mandatory, if and only if, a suitable
>> Device
>>           * Tree match table entry is supplied for the probing device.
>>           */
>>          if (!driver->id_table &&
>>              !i2c_of_match_device(dev->driver->of_match_table, client))
>>                  return -ENODEV;
>>
>> Which needs to be extended to also check for an ACPI match AFAIK
>> you can NOT just replace this with i2c_device_match because that would
>> break manually binding a driver through sysfs.
> 
> I have a stashed change for that, just have no time to look closer.

Care to share that? Between me and Benjamin one of us can hopefully
find the time to test / finish it (should be trivial really).

Regards,

Hans