Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752133AbdF3Sje (ORCPT ); Fri, 30 Jun 2017 14:39:34 -0400 Received: from [138.68.19.158] ([138.68.19.158]:45462 "EHLO freebsd-512mb-sfo2-01.localdomain" rhost-flags-FAIL-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1751666AbdF3Sjd (ORCPT ); Fri, 30 Jun 2017 14:39:33 -0400 Date: Fri, 30 Jun 2017 11:39:27 -0700 From: Mark Rogers To: Frans Klaver Cc: gregkh@linuxfoundation.org, me@tobin.cc, karniksayli1995@gmail.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: ks7010: fix styling WARNINGs Message-ID: <20170630183927.GA13036@ubuntulaptop> References: <1498798361-9965-1-git-send-email-mail@mark-rogers.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 577 Lines: 16 Thank you for your feedback. I guess when making this patch I had the preferred coding style in mind, but didn't ask myself if making the code conform to it would truly improve readability. I agree with all of your comments. Do you think the best course of action is to create a new patch with this change alone and forget the rest? - DPRINTK(1, "ks7010_sdio_remove()\n"); + DPRINTK(1, "%s()\n", __func__); Sorry about the newbie questions and bad patch, I will do better with the next one. Thanks again for your time and feedback, I really appreciate it. Mark