Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752631AbdF3Tqh (ORCPT ); Fri, 30 Jun 2017 15:46:37 -0400 Received: from gateway23.websitewelcome.com ([192.185.50.250]:25636 "EHLO gateway23.websitewelcome.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752207AbdF3Tqg (ORCPT ); Fri, 30 Jun 2017 15:46:36 -0400 Date: Fri, 30 Jun 2017 14:46:33 -0500 Message-ID: <20170630144633.Horde.7_6XB0hRnIIuucUlRN2ico3@gator4166.hostgator.com> From: "Gustavo A. R. Silva" To: Tejun Heo Cc: Sergei Shtylyov , linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] sata_rcar: fix error return code in sata_rcar_probe() References: <20170630052210.GA19186@embeddedgus> <20170630120106.GB16820@htj.duckdns.org> <20170630143645.Horde.FKDELy036LbmnxownuGOszF@gator4166.hostgator.com> In-Reply-To: <20170630143645.Horde.FKDELy036LbmnxownuGOszF@gator4166.hostgator.com> User-Agent: Horde Application Framework 5 Content-Type: text/plain; charset=utf-8; format=flowed; DelSp=Yes MIME-Version: 1.0 Content-Disposition: inline X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 108.167.133.22 X-Exim-ID: 1dR1s9-000yuv-KV X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: gator4166.hostgator.com [108.167.133.22]:29562 X-Source-Auth: garsilva@embeddedor.com X-Email-Count: 6 X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1457 Lines: 54 Quoting "Gustavo A. R. Silva" : > Hi Tejun, Sergei, > > Quoting Tejun Heo : > >> On Fri, Jun 30, 2017 at 12:42:38PM +0300, Sergei Shtylyov wrote: >>> Hello! >>> >>> On 6/30/2017 8:22 AM, Gustavo A. R. Silva wrote: >>> >>>> Print error message and propagate the return value of >>>> platform_get_irq on failure. >>> >>> You should have probably mentioned that this function no longer returns 0 >>> on error. >> >> Yeah, the patches looks good to me but I'd really appreciate more >> context in the changelogs. Gustavo, can you please respin the >> patches? >> > > Absolutely. > > What do you think about the following changelog: > > platform_get_irq() returns an error code, but the sata_rcar driver > ignores it and always returns -EINVAL. This is not correct, and > prevents -EPROBE_DEFER from being propagated properly. > > Print error message and propagate the return value of platform_get_irq > on failure. Also, with this change function sata_rcar_probe() no longer > returns 0 on error. > Errata, this would be final the chagelog: platform_get_irq() returns an error code, but the sata_rcar driver ignores it and always returns -EINVAL. This is not correct, and prevents -EPROBE_DEFER from being propagated properly. Also, notice that platform_get_irq() no longer returns 0 on error. Print error message and propagate the return value of platform_get_irq on failure. Thanks -- Gustavo A. R. Silva