Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S262493AbTFOSLV (ORCPT ); Sun, 15 Jun 2003 14:11:21 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262497AbTFOSLV (ORCPT ); Sun, 15 Jun 2003 14:11:21 -0400 Received: from ossipee.unh.edu ([132.177.137.39]:7131 "EHLO ossipee.unh.edu") by vger.kernel.org with ESMTP id S262493AbTFOSLT (ORCPT ); Sun, 15 Jun 2003 14:11:19 -0400 Date: Sun, 15 Jun 2003 14:25:07 -0400 From: Samuel Thibault To: Dominik Brodowski , torvalds@transmeta.com, cpufreq@www.linux.org.uk, linux-kernel@vger.kernel.org Subject: Re: [2.5 PATCH] bug if cpufreq driver initialization fails Message-ID: <20030615182507.GE686@bouh.unh.edu> Reply-To: Samuel Thibault Mail-Followup-To: Samuel Thibault , Dominik Brodowski , torvalds@transmeta.com, cpufreq@www.linux.org.uk, linux-kernel@vger.kernel.org References: <20021108092241.A1636@brodo.de> <20030614084611.GA10182@bouh.unh.edu> <20030614095646.GA1702@brodo.de> <20030614214943.GA4073@bouh.unh.edu> <20030615095044.GD2009@brodo.de> <20030615180435.GC686@bouh.unh.edu> <20030615191650.J5417@flint.arm.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20030615191650.J5417@flint.arm.linux.org.uk> User-Agent: Mutt/1.4i-nntp X-MailScanner-Information: http://pubpages.unh.edu/notes/mailfiltering.html X-MailScanner: Found to be clean X-MailScanner-SpamCheck: not spam, SpamAssassin (score=-8.3, required 5, BAYES_10, IN_REP_TO, QUOTED_EMAIL_TEXT, REFERENCES, REPLY_WITH_QUOTES, USER_AGENT_MUTT) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1171 Lines: 28 Le dim 15 jun 2003 19:16:50 GMT, Russell King a tapot? sur son clavier : > On Sun, Jun 15, 2003 at 02:04:36PM -0400, Samuel Thibault wrote: > > I hence modified drivers/base/sys.c to have sysdev_driver_register() > > fail as well, and then I also had to modify kernel/cpufreq.c, because > > this failure did not imply a setting cpufreq_driver to NULL (preventing > > me from reinsmoding speedstep-ich: EBUSY) > > Unfortunately, you created a by by doing so. Eg: > > - you have 3 devices on kset.list. > - you successfully register 2 of them with a driver. > - you fail one. > - sysdev_driver_register returns failure. > - module is unloaded while other parts of the kernel have references into > the driver. > - the kernel oopses. Ok, that's what I was wondering, might an exit loop removing the already added driver be done? (the second half of the patch might still be applied as soon as now) Regards, Samuel Thibault - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/