Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752602AbdF3Tyw (ORCPT ); Fri, 30 Jun 2017 15:54:52 -0400 Received: from gateway20.websitewelcome.com ([192.185.49.40]:35389 "EHLO gateway20.websitewelcome.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751919AbdF3Tyv (ORCPT ); Fri, 30 Jun 2017 15:54:51 -0400 Date: Fri, 30 Jun 2017 14:54:48 -0500 Message-ID: <20170630145448.Horde.UwmUU7eGbQI-QPoebHrhBsT@gator4166.hostgator.com> From: "Gustavo A. R. Silva" To: Sergei Shtylyov Cc: Tejun Heo , linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] sata_rcar: fix error return code in sata_rcar_probe() References: <20170630052210.GA19186@embeddedgus> <20170630120106.GB16820@htj.duckdns.org> <20170630143645.Horde.FKDELy036LbmnxownuGOszF@gator4166.hostgator.com> <3944946f-5737-df9f-e8f4-61648f6e0d89@cogentembedded.com> In-Reply-To: <3944946f-5737-df9f-e8f4-61648f6e0d89@cogentembedded.com> User-Agent: Horde Application Framework 5 Content-Type: text/plain; charset=utf-8; format=flowed; DelSp=Yes MIME-Version: 1.0 Content-Disposition: inline X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 108.167.133.22 X-Exim-ID: 1dR208-0014fC-Ew X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: gator4166.hostgator.com [108.167.133.22]:50671 X-Source-Auth: garsilva@embeddedor.com X-Email-Count: 10 X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1451 Lines: 58 Hi Sergei, Quoting Sergei Shtylyov : > On 06/30/2017 10:36 PM, Gustavo A. R. Silva wrote: > >>>>> Print error message and propagate the return value of >>>>> platform_get_irq on failure. >>>> >>>> You should have probably mentioned that this function no longer >>>> returns 0 >>>> on error. >>> >>> Yeah, the patches looks good to me but I'd really appreciate more >>> context in the changelogs. Gustavo, can you please respin the >>> patches? >>> >> >> Absolutely. >> >> What do you think about the following changelog: >> >> platform_get_irq() returns an error code, but the sata_rcar driver >> ignores it and always returns -EINVAL. This is not correct, and > > This *was* correct, because it prevented returning 0 on error. > Yeah, I got it. >> prevents -EPROBE_DEFER from being propagated properly. > > Yes, this is a real problem. > >> Print error message and propagate the return value of platform_get_irq >> on failure. Also, with this change function sata_rcar_probe() no longer >> returns 0 on error. > > It never did -- I was talking about platform_get_irq() which > might return 0 on error until I fixed it: > Yep, I sent a new email immediately after I realized this was incorrect. Please, check it out. > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=e330b9a6bb35dc7097a4f02cb1ae7b6f96df92af > Great work! Thank you -- Gustavo A. R. Silva