Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752693AbdF3UDR (ORCPT ); Fri, 30 Jun 2017 16:03:17 -0400 Received: from mail-lf0-f46.google.com ([209.85.215.46]:36146 "EHLO mail-lf0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752637AbdF3UDP (ORCPT ); Fri, 30 Jun 2017 16:03:15 -0400 Subject: Re: [PATCH] sata_rcar: fix error return code in sata_rcar_probe() To: "Gustavo A. R. Silva" , Tejun Heo References: <20170630052210.GA19186@embeddedgus> <20170630120106.GB16820@htj.duckdns.org> <20170630143645.Horde.FKDELy036LbmnxownuGOszF@gator4166.hostgator.com> <20170630144633.Horde.7_6XB0hRnIIuucUlRN2ico3@gator4166.hostgator.com> Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org From: Sergei Shtylyov Organization: Cogent Embedded Message-ID: Date: Fri, 30 Jun 2017 23:03:05 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170630144633.Horde.7_6XB0hRnIIuucUlRN2ico3@gator4166.hostgator.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1303 Lines: 41 On 06/30/2017 10:46 PM, Gustavo A. R. Silva wrote: >>>>> Print error message and propagate the return value of >>>>> platform_get_irq on failure. >>>> >>>> You should have probably mentioned that this function no longer returns 0 >>>> on error. >>> >>> Yeah, the patches looks good to me but I'd really appreciate more >>> context in the changelogs. Gustavo, can you please respin the >>> patches? >>> >> >> Absolutely. >> >> What do you think about the following changelog: >> >> platform_get_irq() returns an error code, but the sata_rcar driver >> ignores it and always returns -EINVAL. This is not correct, and >> prevents -EPROBE_DEFER from being propagated properly. >> >> Print error message and propagate the return value of platform_get_irq >> on failure. Also, with this change function sata_rcar_probe() no longer >> returns 0 on error. >> > > Errata, this would be final the chagelog: > > platform_get_irq() returns an error code, but the sata_rcar driver > ignores it and always returns -EINVAL. This is not correct, and > prevents -EPROBE_DEFER from being propagated properly. Also, > notice that platform_get_irq() no longer returns 0 on error. > > Print error message and propagate the return value of platform_get_irq > on failure. Now I'm OK with that. > Thanks MBR, Sergei