Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752729AbdF3U1H (ORCPT ); Fri, 30 Jun 2017 16:27:07 -0400 Received: from mx2.suse.de ([195.135.220.15]:47985 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752117AbdF3U1F (ORCPT ); Fri, 30 Jun 2017 16:27:05 -0400 Date: Fri, 30 Jun 2017 22:27:04 +0200 Message-ID: From: Takashi Iwai To: "Gustavo A. R. Silva" Cc: "Jaroslav Kysela" , , Subject: Re: [PATCH v2] ALSA: x86: fix error return code in hdmi_lpe_audio_probe() In-Reply-To: <20170630201841.GA8057@embeddedgus> References: <20170630151244.Horde.nPNra38wHbiLkXMM9mTTsxB@gator4166.hostgator.com> <20170630201841.GA8057@embeddedgus> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.2 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1114 Lines: 41 On Fri, 30 Jun 2017 22:18:41 +0200, Gustavo A. R. Silva wrote: > > Also, > notice that platform_get_irq() no longer returns 0 on error. There is no change by your patch in this regard, right? Takashi > Print error message and propagate the return value of platform_get_irq > on failure. > > Signed-off-by: Gustavo A. R. Silva > --- > Changes in v2: > Fix error in commit message. > > sound/x86/intel_hdmi_audio.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/sound/x86/intel_hdmi_audio.c b/sound/x86/intel_hdmi_audio.c > index c19efc9..a095150 100644 > --- a/sound/x86/intel_hdmi_audio.c > +++ b/sound/x86/intel_hdmi_audio.c > @@ -1758,8 +1758,8 @@ static int hdmi_lpe_audio_probe(struct platform_device *pdev) > /* get resources */ > irq = platform_get_irq(pdev, 0); > if (irq < 0) { > - dev_err(&pdev->dev, "Could not get irq resource\n"); > - return -ENODEV; > + dev_err(&pdev->dev, "Could not get irq resource: %d\n", irq); > + return irq; > } > > res_mmio = platform_get_resource(pdev, IORESOURCE_MEM, 0); > -- > 2.5.0 > >